public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug c++/25955] FAIL: gdb.mi/mi-catch-cpp-exceptions.exp: all with invalid regexp: run until breakpoint in main (unknown output after running)
Date: Sat, 09 May 2020 10:20:53 +0000	[thread overview]
Message-ID: <bug-25955-4717-lLqEwnFmpA@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-25955-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=25955

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Bisects to:

commit 596dc4adfff347b4d8dc1f7e4eb57b8f2f342281 (HEAD, refs/bisect/bad)
Author: Tom Tromey <tom@tromey.com>
Date:   Fri May 8 14:14:05 2020 -0600

    Speed up psymbol reading by removing a copy

    I noticed that cp_canonicalize_string and friends copy a
    unique_xmalloc_ptr to a std::string.  However, this copy isn't
    genuinely needed anywhere, and it serves to slow down DWARF psymbol
    reading.

    This patch removes the copy and updates the callers to adapt.

    This speeds up the reader from 1.906 seconds (mean of 10 runs, of gdb
    on a copy of itself) to 1.888 seconds (mean of 10 runs, on the same
    copy as the first trial).

    gdb/ChangeLog
    2020-05-08  Tom Tromey  <tom@tromey.com>

            * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
            overload.
            <swap_string, m_string>: Remove.
            * symtab.c (demangle_for_lookup, completion_list_add_symbol):
            Update.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2020-05-09 10:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09 10:20 [Bug c++/25955] New: " vries at gcc dot gnu.org
2020-05-09 10:20 ` vries at gcc dot gnu.org [this message]
2020-05-09 10:24 ` [Bug c++/25955] " vries at gcc dot gnu.org
2020-05-09 11:31 ` vries at gcc dot gnu.org
2020-05-09 12:02 ` vries at gcc dot gnu.org
2020-05-09 12:08 ` vries at gcc dot gnu.org
2020-05-09 12:24 ` [Bug gdb/25955] " vries at gcc dot gnu.org
2020-05-09 18:17 ` cvs-commit at gcc dot gnu.org
2020-05-09 18:19 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25955-4717-lLqEwnFmpA@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).