public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/26046] Missing breakpoint location without -readnow
Date: Tue, 26 May 2020 17:38:17 +0000	[thread overview]
Message-ID: <bug-26046-4717-JyIVA3SsZA@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-26046-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=26046

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Tentative patch:
...
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index ec3844188e..bbd57325f5 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -8054,6 +8054,8 @@ scan_partial_symbols (struct partial_die_info *first_die,
CORE_ADDR *lowpc,
            case DW_TAG_subprogram:
            case DW_TAG_inlined_subroutine:
              add_partial_subprogram (pdi, lowpc, highpc, set_addrmap, cu);
+             scan_partial_symbols (pdi->die_child, lowpc, highpc,
+                                   set_addrmap, cu);
              break;
            case DW_TAG_constant:
            case DW_TAG_variable:
@@ -18125,7 +18127,8 @@ load_partial_dies (const struct die_reader_specs
*reader,
       if (!load_all
          && cu->language == language_cplus
          && parent_die != NULL
-         && parent_die->tag == DW_TAG_subprogram)
+         && parent_die->tag == DW_TAG_subprogram
+         && abbrev->tag != DW_TAG_inlined_subroutine)
        {
          info_ptr = skip_one_die (reader, info_ptr + bytes_read, abbrev);
          continue;
@@ -18300,9 +18303,7 @@ load_partial_dies (const struct die_reader_specs
*reader,
              || last_die->tag == DW_TAG_module
              || last_die->tag == DW_TAG_enumeration_type
              || (cu->language == language_cplus
-                 && last_die->tag == DW_TAG_subprogram
-                 && (last_die->name == NULL
-                     || strchr (last_die->name, '<') == NULL))
+                 && last_die->tag == DW_TAG_subprogram)
              || (cu->language != language_c
                  && (last_die->tag == DW_TAG_class_type
                      || last_die->tag == DW_TAG_interface_type
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2020-05-26 17:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26 15:38 [Bug symtab/26046] New: " vries at gcc dot gnu.org
2020-05-26 17:38 ` vries at gcc dot gnu.org [this message]
2020-05-27 10:39 ` [Bug symtab/26046] " vries at gcc dot gnu.org
2020-06-03 21:50 ` cvs-commit at gcc dot gnu.org
2020-06-03 21:51 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-26046-4717-JyIVA3SsZA@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).