From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 6C52F3953424; Fri, 12 Jun 2020 07:13:22 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6C52F3953424
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug testsuite/26110] invalid command name in one test-case aborts
 entire test run
Date: Fri, 12 Jun 2020 07:13:22 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: testsuite
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-26110-4717-ti6oYPTGYB@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-26110-4717@http.sourceware.org/bugzilla/>
References: <bug-26110-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Jun 2020 07:13:22 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D26110

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gn=
u.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D26783bce15ad=
c0316f9167a216519cebcf1ccac3

commit 26783bce15adc0316f9167a216519cebcf1ccac3
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri Jun 12 09:13:17 2020 +0200

    [gdb/testsuite] Don't abort testrun for invalid command in test-case

    Say we add a call to foobar at the end of a test-case, and run the
    test-suite.  We'll run into a dejagnu error:
    ...
    ERROR: (DejaGnu) proc "foobar" does not exist.
    ...
    and the test-suite run is aborted.

    It's reasonable that the test-case is aborted, but it's not reasonable =
that
    the testsuite run is aborted.

    Problems in one test-case should not leak into other test-cases, and th=
ey
    generally don't.  The exception is the "invalid command name" problem d=
ue
to
    an override of ::unknown in dejagnu's framework.exp.

    Fix this by reverting dejagnu's ::unknown override for the duration of =
each
    test-case, using the gdb_init/gdb_finish hooks.

    Tested on x86_64-linux.

    gdb/testsuite/ChangeLog:

    2020-06-12  Tom de Vries  <tdevries@suse.de>

            PR testsuite/26110
            * lib/gdb.exp (gdb_init): Revert dejagnu's override of ::unknow=
n.
            (gdb_finish): Reinstall dejagnu's override of ::unknown.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=