From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id A680538618C3; Tue, 30 Jun 2020 13:55:50 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A680538618C3
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: =?UTF-8?B?W0J1ZyBidWlsZC8yNjE4M10gR0RCIGJ1aWxkIGZhaWxzIHdpdGgg?=
 =?UTF-8?B?ZXJyb3I6IOKAmGNsYXNzIHN0ZDo6YmFzaWNfc3RyaW5nX3ZpZXc8Y2hhcj4=?=
 =?UTF-8?B?4oCZIGhhcyBubyBtZW1iZXIgbmFtZWQg4oCYdG9fc3RyaW5n4oCZ?=
Date: Tue, 30 Jun 2020 13:55:50 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: build
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: tromey at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-26183-4717-ST3ZYAPj94@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-26183-4717@http.sourceware.org/bugzilla/>
References: <bug-26183-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jun 2020 13:55:50 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D26183

--- Comment #8 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gn=
u.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D5ac588997c3c=
2d032d5d5145d9245eb37354c23b

commit 5ac588997c3c2d032d5d5145d9245eb37354c23b
Author: Tom Tromey <tromey@adacore.com>
Date:   Tue Jun 30 07:53:03 2020 -0600

    Do not define basic_string_view::to_string

    gdb's copy of basic_string_view includes a to_string method.  However,
    according to cppreference, this is not a method on the real
    std::basic_string_view:

    https://en.cppreference.com/w/cpp/string/basic_string_view

    This difference matters because gdb_string_view.h will use the
    standard implementation when built with a C++17 or later.  This caused
    PR build/26183.

    This patch fixes the problem by changing the method to be a standalone
    helper function, and then rewriting the uses.  Tested by rebuilding
    with a version of GCC that defaults to C++17.

    (Note that the build still is not clean; and also I noticed that the
    libstdc++ string_view forbids the use of nullptr ... I wonder if gdb
    violates that.)

    gdb/ChangeLog
    2020-06-30  Tom Tromey  <tromey@adacore.com>

            PR build/26183:
            * ada-lang.c (ada_lookup_name_info::ada_lookup_name_info): Use
            gdb::to_string.

    gdbsupport/ChangeLog
    2020-06-30  Tom Tromey  <tromey@adacore.com>

            PR build/26183:
            * gdb_string_view.h (basic_string_view::to_string): Remove.
            (gdb::to_string): New function.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=