public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/26199] GDB goes in busy loop when interrupting non-stop program
Date: Fri, 10 Jul 2020 22:57:47 +0000	[thread overview]
Message-ID: <bug-26199-4717-sp52b77sUA@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-26199-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=26199

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Pedro Alves <palves@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7d3badc6a88b510f96c9aa0bab8f3375292d23bf

commit 7d3badc6a88b510f96c9aa0bab8f3375292d23bf
Author: Pedro Alves <pedro@palves.net>
Date:   Sat Jul 4 19:26:59 2020 +0100

    Fix handle_no_resumed w/ multiple targets

    handle_no_resumed is currently not considering multiple targets.

    Say you have two inferiors 1 and 2, each connected to a different
    target, A and B.

    Now say you set inferior 2 running, with "continue &".

    Now you select a thread of inferior 1, say thread 1.2, and continue in
    the foreground.  All other threads of inferior 1 are left stopped.
    Thread 1.2 exits, and thus target A has no other resumed thread, so it
    reports TARGET_WAITKIND_NO_RESUMED.

    At this point, if both inferiors were running in the same target,
    handle_no_resumed would realize that threads of inferior 2 are still
    executing, so the TARGET_WAITKIND_NO_RESUMED event should be ignored.
    But because handle_no_resumed only walks the threads of the current
    target, it misses noticing that threads of inferior 2 are still
    executing.  The fix is just to walk over all threads of all targets.

    A testcase covering the use case above will be added in a following
    patch.  It can't be added yet because it depends on yet another fix to
    handle_no_resumed not included here.

    gdb/ChangeLog:

            PR gdb/26199
            * infrun.c (handle_no_resumed): Handle multiple targets.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2020-07-10 22:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 21:47 [Bug gdb/26199] New: " simark at simark dot ca
2020-07-02 21:48 ` [Bug gdb/26199] " simark at simark dot ca
2020-07-10 22:57 ` cvs-commit at gcc dot gnu.org
2020-07-10 22:57 ` cvs-commit at gcc dot gnu.org
2020-07-10 22:57 ` cvs-commit at gcc dot gnu.org
2020-07-10 22:57 ` cvs-commit at gcc dot gnu.org [this message]
2020-07-10 22:57 ` cvs-commit at gcc dot gnu.org
2020-07-10 22:57 ` cvs-commit at gcc dot gnu.org
2020-07-10 22:58 ` cvs-commit at gcc dot gnu.org
2020-07-10 23:05 ` palves at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-26199-4717-sp52b77sUA@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).