From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 408ED3857016; Sun,  5 Jul 2020 21:41:32 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 408ED3857016
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tui/26205] [tui] gdb aborts during winheight command
Date: Sun, 05 Jul 2020 21:41:32 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: tui
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-26205-4717-o38CvCl0wI@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-26205-4717@http.sourceware.org/bugzilla/>
References: <bug-26205-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Jul 2020 21:41:32 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D26205

--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom Tromey from comment #2)
> C++17 string_view doesn't allow NULL, and I am going to guess
> that this:
>=20
> static struct tui_win_info *
> tui_partial_win_by_name (gdb::string_view name)
> {
>   struct tui_win_info *best =3D nullptr;
>=20
>   if (name !=3D NULL)
>=20
>=20
> ... perhaps constructs a string_view from NULL to do the
> comparison?  I looked at the callers and I don't see how
> they could pass in NULL here...
>=20
> Anyway, if so, the fix is to remove this "if".

Patch to that effect submitted:
https://sourceware.org/pipermail/gdb-patches/2020-July/170156.html

--=20
You are receiving this mail because:
You are on the CC list for the bug.=