From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 0C559386F02C; Mon, 10 Aug 2020 16:15:56 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0C559386F02C
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug build/26365] [build, arm-elf] Compilation error in
 sim/arm/wrapper.c
Date: Mon, 10 Aug 2020 16:15:55 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: build
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-26365-4717-0tPSLDwb32@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-26365-4717@http.sourceware.org/bugzilla/>
References: <bug-26365-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Aug 2020 16:15:56 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D26365

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
So we have argv:
...
SIM_DESC
sim_open (SIM_OPEN_KIND kind,
          host_callback *cb,
          struct bfd *abfd,
          char * const *argv)
{
...
and then argv is used in this call:
...
  sim_target_parse_arg_array (argv);
...
with prototype:
...
sim_target_parse_arg_array (char ** argv)
...

Looking down further in the implementation in sim_target_parse_command_line:
...
          /* Remove this option from the argv array.  */
          for (arg =3D i; arg < argc; arg ++)
            argv[arg] =3D argv[arg + 1];
...
we seem to modifying argv.

OTOH, the sim_open def matches the decl in include/gdb/remote-sim.h:
...
SIM_DESC sim_open (SIM_OPEN_KIND kind, struct host_callback_struct *callbac=
k,
                   struct bfd *abfd, char * const *argv);
...

--=20
You are receiving this mail because:
You are on the CC list for the bug.=