[Bug python/26586] from_tty argument to Python's gdb.execute is no longer effective

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=26586

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Joel Brobecker <brobecke@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8f9929bb97dc0f0fdf60269ac8c9a7d50746646f

commit 8f9929bb97dc0f0fdf60269ac8c9a7d50746646f
Author: Gareth Rees <grees@undo.io>
Date:   Sat Sep 26 11:01:45 2020 -0700

    gdb: Fix from_tty argument to gdb.execute in Python.

    Prior to commit 56bcdbea2b, the from_tty keyword argument to the
    Python function gdb.execute controlled whether the command took input
    from the terminal. When from_tty=True, "starti" and similar commands
    prompted the user:

        (gdb) python gdb.execute("starti", from_tty=True)
        The program being debugged has been started already.
        Start it from the beginning? (y or n) y
        Starting program: /bin/true

        Program stopped.

    When from_tty=False, these commands did not prompt the user, and "yes"
    was assumed:

        (gdb) python gdb.execute("starti", from_tty=False)

        Program stopped.

    However, after commit 56bcdbea2b, the from_tty keyword argument no
    longer had this effect. For example, as of commit 7ade7fba75:

        (gdb) python gdb.execute("starti", from_tty=True)
        The program being debugged has been started already.
        Start it from the beginning? (y or n) [answered Y; input not from
terminal]
        Starting program: /bin/true

        Program stopped.

    Note the "[answered Y; input not from terminal]" in the output even
    though from_tty=True was requested.

    Looking at commit 56bcdbea2b, it seems that the behaviour of the
    from_tty argument was changed accidentally. The commit message said:

        Let gdb.execute handle multi-line commands

        This changes the Python API so that gdb.execute can now handle
        multi-line commands, like "commands" or "define".

    and there was no mention of changing the effect of the from_tty
    argument. It looks as though the code for setting the instream to
    nullptr was accidentally moved from execute_user_command() to
    execute_control_commands() along with the other scoped restores.

    Accordingly, the simplest way to fix this is to partially reverse
    commit 56bcdbea2b by moving the code for setting the instream to
    nullptr back to execute_user_command() where it was to begin with.

    Additionally, add a test case to reduce the risk of similar breakage
    in future.

    gdb/ChangeLog:

            PR python/26586
            * cli/cli-script.c (execute_control_commands): don't set
            instream to nullptr here as this breaks the from_tty argument
            to gdb.execute in Python.
            (execute_user_command): set instream to nullptr here instead.

    gdb/testsuite/ChangeLog:

            PR python/26586
            * gdb.python/python.exp: add test cases for the from_tty
            argument to gdb.execute.

-- 
You are receiving this mail because:
You are on the CC list for the bug.