* [Bug gdb/26683] FAIL: gdb.base/info-types-c++.exp: info types
2020-09-30 14:10 [Bug gdb/26683] New: FAIL: gdb.base/info-types-c++.exp: info types vries at gcc dot gnu.org
@ 2020-09-30 14:51 ` vries at gcc dot gnu.org
2020-09-30 15:05 ` vries at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2020-09-30 14:51 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26683
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tromey at sourceware dot org
--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
Bisects to:
...
2c830f547588220588f2a0a876b86e3f9062f9e1 is the first bad commit
commit 2c830f547588220588f2a0a876b86e3f9062f9e1
Author: Tom Tromey <tom@tromey.com>
Date: Tue Sep 29 18:49:08 2020 -0600
Change some uses of DW_STRING to string method
This changes some of the simpler spots to use attribute::string rather
than DW_STRING.
gdb/ChangeLog
2020-09-29 Tom Tromey <tom@tromey.com>
* dwarf2/read.c (partial_die_info::read)
(dwarf2_const_value_attr, anonymous_struct_prefix, )
(dwarf2_name, dwarf2_fetch_constant_bytes): Use
attribute::as_string.
gdb/ChangeLog | 7 ++++++
gdb/dwarf2/read.c | 64 +++++++++++++++++++++++++++++++------------------------
2 files changed, 43 insertions(+), 28 deletions(-)
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug gdb/26683] FAIL: gdb.base/info-types-c++.exp: info types
2020-09-30 14:10 [Bug gdb/26683] New: FAIL: gdb.base/info-types-c++.exp: info types vries at gcc dot gnu.org
2020-09-30 14:51 ` [Bug gdb/26683] " vries at gcc dot gnu.org
@ 2020-09-30 15:05 ` vries at gcc dot gnu.org
2020-09-30 15:10 ` vries at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2020-09-30 15:05 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26683
--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
Difference in output:
...
$ diff -u 1 2
--- 1 2020-09-30 17:02:12.704346332 +0200
+++ 2 2020-09-30 17:00:04.920629054 +0200
@@ -1,13 +1,11 @@
File /home/vries/gdb_versions/devel/src/gdb/testsuite/gdb.base/info-types.c:
98: CL;
-42: anon_struct_t;
-65: anon_union_t;
21: baz_t;
33: enum_t;
56: union_t;
52: typedef enum {...} anon_enum_t;
-45: typedef anon_struct_t anon_struct_t;
-68: typedef anon_union_t anon_union_t;
+45: typedef struct {...} anon_struct_t;
+68: typedef union {...} anon_union_t;
28: typedef baz_t baz;
31: typedef baz_t * baz_ptr;
27: typedef baz_t baz_t;
@@ -20,8 +18,8 @@
16: typedef int my_int_t;
104: typedef CL * my_ptr;
54: typedef enum {...} nested_anon_enum_t;
-47: typedef anon_struct_t nested_anon_struct_t;
-70: typedef anon_union_t nested_anon_union_t;
+47: typedef struct {...} nested_anon_struct_t;
+70: typedef union {...} nested_anon_union_t;
30: typedef baz_t nested_baz;
29: typedef baz_t nested_baz_t;
39: typedef enum_t nested_enum_t;
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug gdb/26683] FAIL: gdb.base/info-types-c++.exp: info types
2020-09-30 14:10 [Bug gdb/26683] New: FAIL: gdb.base/info-types-c++.exp: info types vries at gcc dot gnu.org
2020-09-30 14:51 ` [Bug gdb/26683] " vries at gcc dot gnu.org
2020-09-30 15:05 ` vries at gcc dot gnu.org
@ 2020-09-30 15:10 ` vries at gcc dot gnu.org
2020-09-30 15:48 ` vries at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2020-09-30 15:10 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26683
--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
These fails bisect to the same commit, looks related:
...
FAIL: gdb.cp/anon-struct.exp: print type of t::t
FAIL: gdb.cp/anon-struct.exp: print type of X::t2
FAIL: gdb.cp/anon-struct.exp: print type of X::t2::t2
FAIL: gdb.cp/anon-struct.exp: print type of t3::~t3
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug gdb/26683] FAIL: gdb.base/info-types-c++.exp: info types
2020-09-30 14:10 [Bug gdb/26683] New: FAIL: gdb.base/info-types-c++.exp: info types vries at gcc dot gnu.org
` (2 preceding siblings ...)
2020-09-30 15:10 ` vries at gcc dot gnu.org
@ 2020-09-30 15:48 ` vries at gcc dot gnu.org
2020-09-30 17:05 ` tromey at sourceware dot org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2020-09-30 15:48 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26683
--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
Tentative patch:
...
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 70d2091148..57e2ce77bf 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -22633,6 +22633,7 @@ dwarf2_name (struct die_info *die, struct dwarf2_cu
*cu)
if (!attr || attr_name == NULL)
{
attr = dw2_linkage_name_attr (die, cu);
+ attr_name = attr == nullptr ? nullptr : attr->as_string ();
if (attr == NULL || attr_name == NULL)
return NULL;
@@ -22647,6 +22648,7 @@ dwarf2_name (struct die_info *die, struct dwarf2_cu
*cu)
DW_STRING (attr) = objfile->intern (demangled.get ());
DW_STRING_IS_CANONICAL (attr) = 1;
+ attr_name = attr->as_string ();
}
/* Strip any leading namespaces/classes, keep only the
...
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug gdb/26683] FAIL: gdb.base/info-types-c++.exp: info types
2020-09-30 14:10 [Bug gdb/26683] New: FAIL: gdb.base/info-types-c++.exp: info types vries at gcc dot gnu.org
` (3 preceding siblings ...)
2020-09-30 15:48 ` vries at gcc dot gnu.org
@ 2020-09-30 17:05 ` tromey at sourceware dot org
2020-09-30 19:47 ` [Bug symtab/26683] " vries at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: tromey at sourceware dot org @ 2020-09-30 17:05 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26683
--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
This patch looks good to me.
Thanks for doing this, and sorry.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug symtab/26683] FAIL: gdb.base/info-types-c++.exp: info types
2020-09-30 14:10 [Bug gdb/26683] New: FAIL: gdb.base/info-types-c++.exp: info types vries at gcc dot gnu.org
` (4 preceding siblings ...)
2020-09-30 17:05 ` tromey at sourceware dot org
@ 2020-09-30 19:47 ` vries at gcc dot gnu.org
2020-09-30 19:49 ` cvs-commit at gcc dot gnu.org
2020-09-30 19:49 ` vries at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2020-09-30 19:47 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26683
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|gdb |symtab
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug symtab/26683] FAIL: gdb.base/info-types-c++.exp: info types
2020-09-30 14:10 [Bug gdb/26683] New: FAIL: gdb.base/info-types-c++.exp: info types vries at gcc dot gnu.org
` (5 preceding siblings ...)
2020-09-30 19:47 ` [Bug symtab/26683] " vries at gcc dot gnu.org
@ 2020-09-30 19:49 ` cvs-commit at gcc dot gnu.org
2020-09-30 19:49 ` vries at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2020-09-30 19:49 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26683
--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=95eb9e54a51fdb819c8525a0a33138d861f31bc8
commit 95eb9e54a51fdb819c8525a0a33138d861f31bc8
Author: Tom de Vries <tdevries@suse.de>
Date: Wed Sep 30 21:49:01 2020 +0200
[gdb] Fix regression in dwarf2_name
Since commit 2c830f5475 "Change some uses of DW_STRING to string method" we
have these regressions:
...
FAIL: gdb.base/info-types-c++.exp: info types
FAIL: gdb.cp/anon-struct.exp: print type of t::t
FAIL: gdb.cp/anon-struct.exp: print type of X::t2
FAIL: gdb.cp/anon-struct.exp: print type of X::t2::t2
FAIL: gdb.cp/anon-struct.exp: print type of t3::~t3
...
Fix these in dwarf2_name by updating attr_name each time attr is updated.
Tested on x86_64-linux.
gdb/ChangeLog:
2020-09-30 Tom de Vries <tdevries@suse.de>
PR symtab/26683
* dwarf2/read.c (dwarf2_name): Update attr_name after attr is
updated.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug symtab/26683] FAIL: gdb.base/info-types-c++.exp: info types
2020-09-30 14:10 [Bug gdb/26683] New: FAIL: gdb.base/info-types-c++.exp: info types vries at gcc dot gnu.org
` (6 preceding siblings ...)
2020-09-30 19:49 ` cvs-commit at gcc dot gnu.org
@ 2020-09-30 19:49 ` vries at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2020-09-30 19:49 UTC (permalink / raw)
To: gdb-prs
https://sourceware.org/bugzilla/show_bug.cgi?id=26683
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #7 from Tom de Vries <vries at gcc dot gnu.org> ---
Patch fixing regression committed, marking resolved-fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 9+ messages in thread