[Bug ada/26732] New: FAIL: gdb.ada/mi_catch_ex.exp: continue to exception catchpoint hit (unknown output after running)

[Bug ada/26732] New: FAIL: gdb.ada/mi_catch_ex.exp: continue to exception catchpoint hit (unknown output after running)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26732

            Bug ID: 26732
           Summary: FAIL: gdb.ada/mi_catch_ex.exp: continue to exception
                    catchpoint hit (unknown output after running)
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ada
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

With current trunk (commit 7b47a31256) I see:
...
FAIL: gdb.ada/mi_catch_ex.exp: continue to exception catchpoint hit (unknown
output after running)
FAIL: gdb.ada/mi_catch_ex.exp: continue to assert failure catchpoint hit
(unknown output after running)
FAIL: gdb.ada/mi_catch_ex.exp: continue to unhandled exception catchpoint hit
(unknown output after running)
FAIL: gdb.ada/mi_catch_ex_hand.exp: continue to end (2)
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/26732] FAIL: gdb.ada/mi_catch_ex.exp: continue to exception catchpoint hit (unknown output after running)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26732

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #0)
> With current trunk (commit 7b47a31256) I see:
> ...
> FAIL: gdb.ada/mi_catch_ex.exp: continue to exception catchpoint hit (unknown
> output after running)

In more detail:
...
PASS: gdb.ada/mi_catch_ex.exp: catch unhandled exceptions
-exec-continue
^running
*running,thread-id="all"
(gdb) 
mi_expect_stop: expecting:
\*stopped,reason="breakpoint-hit",disp="keep",bkptno="[0-9]+",exception-name="PROGRAM_ERROR(",exception-message="foo\.adb:[0-9]+
explicit raise)?",frame={addr="0x[0-9A-Fa-f]+",func="foo",args=\[\],(?:file="[^
]*.*",fullname="(/[^\n]*/|\\\\[^\\]+\\[^\n]+\\|\\[^\\][^\n]*\\|[a-zA-Z]:[^\n]*\\).*",line=".*",arch="[^
]*"|from=".*")}.*,thread-id="[0-9]+",stopped-threads=[^
]*
(=thread-selected,id="[0-9]+"
|=(?:breakpoint-created|breakpoint-deleted)[^
]+"
)*[(]gdb[)] 
$
=breakpoint-modified,bkpt={number="2",type="catchpoint",disp="keep",enabled="y",what="all
Ada
exceptions",thread-groups=["i1"],times="1",original-location="__gnat_debug_raise_exception"}
~"\nCatchpoint "
~"2, CONSTRAINT_ERROR (foo.adb:20 explicit raise) at 0x0000000000401faa in foo
() at
/home/vries/gdb_versions/devel/binutils-gdb.git/gdb/testsuite/gdb.ada/mi_catch_ex/foo.adb:20\n"
~"20\t      raise Constraint_Error;  -- SPOT1\n"
*stopped,reason="breakpoint-hit",disp="keep",bkptno="2",exception-name="CONSTRAINT_ERROR",exception-message="foo.adb:20
explicit
raise",frame={addr="0x0000000000401faa",func="foo",args=[],file="/home/vries/gdb_versions/devel/binutils-gdb.git/gdb/testsuite/gdb.ada/mi_catch_ex/foo.adb",fullname="/home/vries/gdb_versions/devel/binutils-gdb.git/gdb/testsuite/gdb.ada/mi_catch_ex/foo.adb",line="20",arch="i386:x86-64"},thread-id="1",stopped-threads="all",core="2"
(gdb) 
got
=breakpoint-modified,bkpt={number="2",type="catchpoint",disp="keep",enabled="y",what="all
Ada
exceptions",thread-groups=["i1"],times="1",original-location="__gnat_debug_raise_exception"}
~"\nCatchpoint "
~"2, CONSTRAINT_ERROR (foo.adb:20 explicit raise) at 0x0000000000401faa in foo
() at
/home/vries/gdb_versions/devel/binutils-gdb.git/gdb/testsuite/gdb.ada/mi_catch_ex/foo.adb:20\n"
~"20\t      raise Constraint_Error;  -- SPOT1\n"
*stopped,reason="breakpoint-hit",disp="keep",bkptno="2",exception-name="CONSTRAINT_ERROR",exception-message="foo.adb:20
explicit
raise",frame={addr="0x0000000000401faa",func="foo",args=[],file="/home/vries/gdb_versions/devel/binutils-gdb.git/gdb/testsuite/gdb.ada/mi_catch_ex/foo.adb",fullname="/home/vries/gdb_versions/devel/binutils-gdb.git/gdb/testsuite/gdb.ada/mi_catch_ex/foo.adb",line="20",arch="i386:x86-64"},thread-id="1",stopped-threads="all",core="2"
(gdb) 

FAIL: gdb.ada/mi_catch_ex.exp: continue to exception catchpoint hit (unknown
output after running)
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/26732] FAIL: gdb.ada/mi_catch_ex.exp: continue to exception catchpoint hit (unknown output after running)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26732

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |palves at redhat dot com

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
b75d55d4d2fdcabb0e198ef456bcc78d84ad5c7c is the first bad commit
commit b75d55d4d2fdcabb0e198ef456bcc78d84ad5c7c
Author: Pedro Alves <pedro@palves.net>
Date:   Sun Oct 11 21:58:31 2020 +0100

    Eliminate mi_run_to_main, introduce mi_clean_restart

    Since we now have mi_runto_main which is like runto_main, eliminate
    mi_run_to_main, in favor of a new MI clean_restart counterpart --
    mi_clean_restart -- and mi_runto_main.

    This makes MI testcases look a bit more like CLI testcases.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug ada/26732] FAIL: gdb.ada/mi_catch_ex.exp: continue to exception catchpoint hit (unknown output after running)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26732

--- Comment #3 from Tom de Vries <vries at gcc dot gnu.org> ---
This makes the test pass again:
...
diff --git a/gdb/testsuite/gdb.ada/mi_catch_ex.exp
b/gdb/testsuite/gdb.ada/mi_catch_ex.exp

index 103ec85f86..35efe8ef29 100644
--- a/gdb/testsuite/gdb.ada/mi_catch_ex.exp
+++ b/gdb/testsuite/gdb.ada/mi_catch_ex.exp
@@ -129,6 +129,9 @@ with_test_prefix "scenario 2" {
     }
 }

+mi_delete_breakpoints
+
+
 mi_gdb_test "-catch-exception -e Program_Error" \
            
"\\^done,bkptno=\"$decimal\",bkpt={.*disp=\"keep\",enabled=\"y\",what=\"`Program_
Error' Ada exception\",.*}" \
             "catch Program_Error"
...

That was previously done by mi_run_to_main.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/26732] FAIL: gdb.ada/mi_catch_ex.exp: continue to exception catchpoint hit (unknown output after running)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26732

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|ada                         |testsuite

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/26732] FAIL: gdb.ada/mi_catch_ex.exp: continue to exception catchpoint hit (unknown output after running)

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26732

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=8c8bd0babc6039a4cef7d60d57b1b68e7a7f2e70

commit 8c8bd0babc6039a4cef7d60d57b1b68e7a7f2e70
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Oct 14 13:17:58 2020 +0200

    [gdb/testsuite] Fix gdb.ada/mi_catch_ex{,_hand}.exp FAILs

    The test-case gdb.ada/mi_catch_ex.exp tests two scenarios.

    The two scenarios are separated by:
    - a mi_run_to_main (before commit b75d55d4d2 "Eliminate mi_run_to_main,
      introduce mi_clean_restart")
    - a mi_runto_main (after that commit)

    The now removed mi_run_to_main contained a mi_delete_breakpoints, while
    mi_runto_main does not, which causes FAILs in the second scenario.

    Fix this by adding the missing mi_delete_breakpoints in the test-case, and
    likewise in gdb.ada/mi_catch_ex_hand.exp.

    Reg-tested on x86_64-linux.

    gdb/testsuite/ChangeLog:

    2020-10-14  Tom de Vries  <tdevries@suse.de>

            PR testsuite/26732
            * gdb.ada/mi_catch_ex.exp: Do mi_delete_breakpoints before running
            scenario 2.
            * gdb.ada/mi_catch_ex_hand.exp: Same.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug testsuite/26732] FAIL: gdb.ada/mi_catch_ex.exp: continue to exception catchpoint hit (unknown output after running)

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=26732

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |11.1
             Status|NEW                         |RESOLVED

--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
Marking resolved-fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.