public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tui/26922] New: FAIL: gdb.tui/tui-layout-asm.exp: scroll to end of assembler (scroll failed)
Date: Thu, 19 Nov 2020 16:34:10 +0000	[thread overview]
Message-ID: <bug-26922-4717@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=26922

            Bug ID: 26922
           Summary: FAIL: gdb.tui/tui-layout-asm.exp: scroll to end of
                    assembler (scroll failed)
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: tui
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

When running test-case gdb.tui/tui-layout-asm.exp with target board
unix/-fPIE/-pie we run into:
...
FAIL: gdb.tui/tui-layout-asm.exp: scroll to end of assembler (scroll failed)
...

Using some printf debugging:
...
index 96fb043321f..20863a6a81b 100644
--- a/gdb/testsuite/gdb.tui/tui-layout-asm.exp
+++ b/gdb/testsuite/gdb.tui/tui-layout-asm.exp
@@ -61,7 +61,12 @@ while (1) {
     if {[Term::wait_for [string_to_regexp $line]] \
            && [Term::get_line 1] == $line} {
        # We scrolled successfully.
+       pass "$testname (scroll cnt: $down_count)"
+       Term::dump_screen
     } else {
+       verbose -log "\n"
+       verbose -log "wait_for  : '$line'"
+       verbose -log "first line: '[Term::get_line 1]'"
        fail "$testname (scroll failed)"
        Term::dump_screen
        break
...
we can see what goes wrong.

We get:
...
wait_for  : '|    0x6b5                               data16 cs nopw
0x0(%rax,%rax,1)       |\
'
first line: '|    0x6b5                       data16 cs nopw 0x0(%rax,%rax,1)  
            |\
'
...
So, AFAIU this is about indentation.

TUI's behaviour doesn't look wrong to me, so I guess it's a question of
updating the test-case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2020-11-19 16:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 16:34 vries at gcc dot gnu.org [this message]
2020-11-19 16:39 ` [Bug tui/26922] " vries at gcc dot gnu.org
2020-11-19 16:39 ` vries at gcc dot gnu.org
2020-11-26 13:52 ` vries at gcc dot gnu.org
2021-02-05 16:31 ` vries at gcc dot gnu.org
2021-02-06 22:22 ` cvs-commit at gcc dot gnu.org
2021-02-06 22:25 ` [Bug testsuite/26922] " vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-26922-4717@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).