[Bug mi/26935] [gdb/testsuite] Using gold in gdb.base/morestack.exp causes incorrect debug info

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=26935

--- Comment #4 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #3)
> (In reply to Tom de Vries from comment #2)
> > But with ld, we have:
> > ...
> > linetable: ((struct linetable *) 0x2f18420):
> > INDEX  LINE   ADDRESS            IS-STMT
> > 0      END    0x56555004         Y
> > 1      109    0x56555b8b         Y
> > ...
> > If we're dropping lines 636 and 637 because the addresses are out of range,
> > I'd say it makes sense to drop the corresponding END as well.
> 
> This seems to work:
> ...
> diff --git a/gdb/buildsym.c b/gdb/buildsym.c
> index 9525962d966..f2560dd7fe7 100644
> --- a/gdb/buildsym.c
> +++ b/gdb/buildsym.c
> @@ -714,6 +714,14 @@ buildsym_compunit::record_line (struct subfile
> *subfile, int line
> ,
>             break;
>           subfile->line_vector->nitems--;
>         }
> +
> +      /* Ignore an end-of-sequence marker marking an empty sequence.  */
> +      struct linetable_entry *last
> +       = (subfile->line_vector->nitems == 0
> +          ? nullptr
> +          : &subfile->line_vector->item[subfile->line_vector->nitems - 1]);
> +      if (last == nullptr || last->line == 0)
> +       return;
>      }
>  
>    e = subfile->line_vector->item + subfile->line_vector->nitems++;
> ...

Patch survives testsuite run.

-- 
You are receiving this mail because:
You are on the CC list for the bug.