public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug testsuite/26947] gdb.tui/new-layout.exp and tcl 8.5
Date: Thu, 10 Dec 2020 22:44:53 +0000	[thread overview]
Message-ID: <bug-26947-4717-6ZOjLcn9S4@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-26947-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=26947

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=10067028372e0f50799ec93843490db42c619e39

commit 10067028372e0f50799ec93843490db42c619e39
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Dec 10 23:44:49 2020 +0100

    [gdb/testsuite] Fix gdb.tui/new-layout.exp with tcl 8.5

    In commit 4d91ddd342 "[gdb/testsuite] Fix unbalanced braces in
    gdb.tui/new-layout.exp", I tried to fix a problem with test-case
    gdb.tui/new-layout.exp when running with tcl 8.5.

    However, at that point I only had access to the log containing the failure,
    and unfortunately my patch turned out not to be effective.

    So, finally fix this problem by guarding the problematic code with:
    ...
    if { [tcl_version_at_least 8 6] } { ... }
    ...

    Tested on x86_64-linux, specifically SLE-11 where I ran into the failure.

    gdb/testsuite/ChangeLog:

    2020-12-10  Tom de Vries  <tdevries@suse.de>

            PR testsuite/26947
            * gdb.tui/new-layout.exp: Don't execute tests with unbalanced curly
            braces for tcl 8.5 and earlier.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2020-12-10 22:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 23:40 [Bug testsuite/26947] New: " vries at gcc dot gnu.org
2020-11-26  0:39 ` [Bug testsuite/26947] " vries at gcc dot gnu.org
2020-12-10 16:56 ` vries at gcc dot gnu.org
2020-12-10 22:44 ` cvs-commit at gcc dot gnu.org [this message]
2020-12-10 22:45 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-26947-4717-6ZOjLcn9S4@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).