public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug testsuite/26950] FAIL: gdb.arch/amd64-disp-step-avx.exp: vex2: continue to test_rip_vex2_end
Date: Sat, 04 Sep 2021 08:44:14 +0000	[thread overview]
Message-ID: <bug-26950-4717-l24r7mrwTA@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-26950-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=26950

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=10f3fbece94463282d293305de5ac7381c326e3b

commit 10f3fbece94463282d293305de5ac7381c326e3b
Author: Tom de Vries <tdevries@suse.de>
Date:   Sat Sep 4 10:44:10 2021 +0200

    [gdb/testsuite] Check avx support in gdb.arch/amd64-disp-step-avx.exp

    On a machine on Open Build Service I'm running into a SIGILL for test-case
    gdb.arch/amd64-disp-step-avx.exp:
    ...
    Program received signal SIGILL, Illegal instruction.^M
    test_rip_vex2 () at gdb.arch/amd64-disp-step-avx.S:40^M
    40              vmovsd ro_var(%rip),%xmm0^M
    (gdb) FAIL: gdb.arch/amd64-disp-step-avx.exp: vex2: \
      continue to test_rip_vex2_end
    ...
    The SIGILL happens when trying to execute the first avx instruction in the
    executable.

    I can't directly access the machine, but looking at the log for test-case
    gdb.arch/i386-avx.exp, it seems that there's no avx support:
    ...
    Breakpoint 1, main (argc=1, argv=0x7fffffffd6b8) at
gdb.arch/i386-avx.c:68^M
    68        if (have_avx ())^M
    (gdb) print have_avx ()^M
    $1 = 0^M
    ...

    Fix this by:
    - adding a gdb_caching_proc have_avx, similar to have_mpx, using the
have_avx
      function from gdb.arch/i386-avx.c
    - using proc have_avx in both
gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp
      and gdb/testsuite/gdb.arch/i386-avx.exp.

    Tested on my x86_64-linux laptop with avx support, where both test-cases
pass.

    gdb/testsuite/ChangeLog:

    2021-09-04  Tom de Vries  <tdevries@suse.de>

            PR testsuite/26950
            * gdb/testsuite/gdb.arch/i386-avx.c (main): Remove call to
have_avx.
            (have_avx): Move ...
            * gdb/testsuite/lib/gdb.exp (have_avx): ... here.  New proc.
            * gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp: Use have_avx.
            * gdb/testsuite/gdb.arch/i386-avx.exp: Same.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-09-04  8:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 12:20 [Bug testsuite/26950] New: " vries at gcc dot gnu.org
2020-11-27  8:47 ` [Bug testsuite/26950] " vries at gcc dot gnu.org
2021-09-04  8:44 ` cvs-commit at gcc dot gnu.org [this message]
2021-09-04 10:11 ` cvs-commit at gcc dot gnu.org
2021-09-04 10:12 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-26950-4717-l24r7mrwTA@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).