[Bug testsuite/26997] [-m32] FAIL: gdb.fortran/array-slices.exp: repack=on: test 9: check sizes match

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=26997

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=10f92414d6d4a5f8eb8cbb2bf39ca86c1f9c1da5

commit 10f92414d6d4a5f8eb8cbb2bf39ca86c1f9c1da5
Author: Tom de Vries <tdevries@suse.de>
Date:   Fri Jan 15 12:14:45 2021 +0100

    [gdb/testsuite] Fix gdb.fortran/array-slices.exp with -m32

    When running test-case gdb.fortran/array-slices.exp with target board
    unix/-m32, we run into:
    ...
    (gdb) print /x &array4d^M
    $69 = 0xffffb620^M
    (gdb) print /x (&array4d) + sizeof (array4d)^M
    $70 = 0x95c620^M
    (gdb) FAIL: gdb.fortran/array-slices.exp: repack=on: test 9: check sizes
match
    ...
    The expressions calculate the start and end of an array, but the
calculation
    of the end expression has an unexpected result (given that it lies before
the
    start of the array).  By printing "sizeof (array4d)" as a separate
    expression:
    ...
    (gdb) print /x sizeof (array4d)
    $1 = 0xc40
    ...
    it becomes clear we expected to get 0xffffb620 + 0xc40 == 0xffffc260
instead.

    The problem is that using the '&' returns a pointer type:
    ...
    (gdb) p &array4d
    $5 = (PTR TO -> ( integer(kind=4) (-3:3,7:10,-3:3,-10:-7) )) 0xffffbe00
    ...
    which has the consequence that the addition is done as pointer arithmetic.

    Fix this by using the result of "print /x &array4d" instead of &array4d in
the
    addition.

    Tested on x86_64-linux.

    gdb/testsuite/ChangeLog:

    2021-01-15  Tom de Vries  <tdevries@suse.de>

            PR testsuite/26997
            * gdb.fortran/array-slices.exp (run_test): Avoid pointer arithmetic
            when adding sizeof.

-- 
You are receiving this mail because:
You are on the CC list for the bug.