public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "kelly at 219design dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug cli/27125] unwanted interaction of [-ex "bt"] with [-batch -return-child-result]. used to work in gdb 8.1
Date: Tue, 29 Dec 2020 05:11:25 +0000	[thread overview]
Message-ID: <bug-27125-4717-R1vRKb2KRj@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27125-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=27125

--- Comment #2 from kelly at 219design dot com ---
prior to commit b0f492b90f3d13da8a, we had:


  if (batch_flag)
    {
      /* We have hit the end of the batch file.  */
      quit_force (NULL, 0);
    }


after that commit, we have (and currently still have):

  if (batch_flag)
    {
      int error_status = EXIT_FAILURE;
      int *exit_arg = ret == 0 ? &error_status : NULL;

      /* We have hit the end of the batch file.  */
      quit_force (exit_arg, 0);
    }

In the absence of "-return-child-result", I wholeheartedly agree with the
outcome of commit b0f492b90f3d13da8a.

When using "-return-child-result", however, it isn't obvious to me whether the
new behavior is best.

I would pose the question to users of "-return-child-result":

When "-return-child-result" is active, should that result in executing the old
(pre-b0f492b90f3d13da8a) behavior of quit_force? The first variation shown
above?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2020-12-29  5:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-29  1:22 [Bug cli/27125] New: " kelly at 219design dot com
2020-12-29  4:56 ` [Bug cli/27125] " kelly at 219design dot com
2020-12-29  4:58 ` kelly at 219design dot com
2020-12-29  5:11 ` kelly at 219design dot com [this message]
2020-12-29  5:15 ` kelly at 219design dot com
2020-12-29 18:38 ` kelly at 219design dot com
2021-01-05 13:51 ` cbiesinger at google dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27125-4717-R1vRKb2KRj@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).