public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "mehmetgelisin at aol dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug rust/27194] put rust demangler on 10.x branch
Date: Fri, 10 Sep 2021 19:38:27 +0000	[thread overview]
Message-ID: <bug-27194-4717-2teE2TFGS6@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27194-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=27194

Mehmet gelisin <mehmetgelisin at aol dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mehmetgelisin at aol dot com

--- Comment #14 from Mehmet gelisin <mehmetgelisin at aol dot com> ---
he issue lies with the fact that we have a DIE in a CU A referring to a DIE in
a CU B (using DW_AT_abstract_origin). http://www-look-4.com/  The DIEs for CU B
are not loaded yet (or rather, have been unloaded due to DWARF CU aging stuff),
and we try to load them using:

      /* If necessary, add it to the queue and load its DIEs.  */
http://www.compilatori.com/
      if (maybe_queue_comp_unit (cu, per_cu, per_objfile, cu->language))
        load_full_comp_unit (per_cu, per_objfile, per_objfile->get_cu (per_cu),
                             false, cu->language);
http://www.wearelondonmade.com/

Since the CU is already queued for expansion, maybe_queue_comp_unit returns
false and we don't call load_full_comp_unit. http://www.jopspeech.com/ I think
maybe_queue_comp_unit is the wrong thing to call here, because "queuing for
symtab expansion" is http://joerg.li/ unrelated to "loading the DIEs in
memory".  We should rather check: "are the DIEs for per_cu loaded
http://connstr.net/  into memory yet?  if not do it now", which is what the
patch below implements.

http://embermanchester.uk/ 
@@ -22937,12 +22939,15 @@ follow_die_offset (sect_offset sect_off, int
offset_in_dwz,
 http://www.slipstone.co.uk/       per_cu = dwarf2_find_containing_comp_unit
(sect_off, offset_in_dwz,
                                                 per_objfile);

-  http://www.logoarts.co.uk/     /* If necessary, add it to the queue and load
its DIEs.  */
-      if (maybe_queue_comp_unit (cu, per_cu, per_objfile, cu->language))
-       load_full_comp_unit (per_cu, per_objfile, per_objfile->get_cu (per_cu),
-                            false, cu->language);
http://www.acpirateradio.co.uk/ 
-
       target_cu = per_objfile->get_cu (per_cu);
+      if (target_cu == nullptr)
+       {
+         load_full_comp_unit (per_cu, per_objfile, per_objfile->get_cu
https://waytowhatsnext.com/  (per_cu),
+                              false, cu->language);
+         target_cu = per_objfile->get_cu (per_cu);
+       }
+
+      gdb_assert (target_cu != nullptr);
     } __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007fc878bb0859 in __GI_abort () at abort.c:79
https://www.webb-dev.co.uk/ 
#2  0x000056229e1f0e76 in dump_core () at
../../../../binutils-gdb/gdb/utils.c:204
#3  0x000056229e1f1799 in internal_vproblem(internal_problem *, const char *,
int, const char *, typedef __va_list_tag __va_list_tag *)
(problem=0x56229f7c09e0 <internal_error_problem>, 
http://www.iu-bloomington.com/ 
    file=0x56229e7cb208 "../../../../binutils-gdb/gdb/dwarf2/read.c",
line=9251, 
    fmt=0x56229e7ca848 "%s: Assertion `%s' failed.", ap=0x7ffc18d82410)
    at ../../../../binutils-gdb/gdb/utils.c:414
#4  0x000056229e1f1890 in internal_verror (
    file=0x56229e7cb208 "../../../../binutils-gdb/gdb/dwarf2/read.c",
line=9251, 
    fmt=0x56229e7ca848 "%s: Assertion `%s' failed.", ap=0x7ffc18d82410)
    at ../../../../binutils-gdb/gdb/utils.c:439
#5  0x000056229e685fda in internal_error (
    file=0x56229e7cb208 "../../../../binutils-gdb/gdb/dwarf2/read.c",
line=9251, 
    fmt=0x56229e7ca848 "%s: Assertion `%s' failed.") at
../../../../binutils-gdb/gdbsupport/errors.cc:55
#6  0x000056229d7c1103 in load_full_comp_unit (this_cu=0x5622a1d2f220,
per_objfile=0x5622a1351a10, 
    existing_cu=0x5622b648d2f0, skip_partial=false,
pretend_language=language_minimal) https://komiya-dental.com/
    at ../../../../binutils-gdb/gdb/dwarf2/read.c:9251
#7  0x000056229d783f35 in load_cu (per_cu=0x5622a1d2f220,
per_objfile=0x5622a1351a10, 
    skip_partial=false) at ../../../../binutils-gdb/gdb/dwarf2/read.c:2389
#8  0x000056229d7840ad in dw2_do_instantiate_symtab (per_cu=0x5622a1d2f220,
per_objfile=0x5622a1351a10, 
    skip_partial=false) at ../../../../binutils-gdb/gdb/dwarf2/read.c:2420
#9  0x000056229d7c0926 in dwarf2_psymtab::expand_psymtab (this=0x5622a293efa0,
objfile=0x5622a1d5f4b0)
    at ../../../../binutils-gdb/gdb/dwarf2/read.c:9183
#10 0x000056229d7bf853 in dwarf2_psymtab::read_symtab (this=0x5622a293efa0,
objfile=0x5622a1d5f4b0)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-09-10 19:38 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-16 17:07 [Bug rust/27194] New: " tromey at sourceware dot org
2021-01-16 17:07 ` [Bug rust/27194] " tromey at sourceware dot org
2021-01-16 17:27 ` tromey at sourceware dot org
2021-06-27 17:51 ` ahmedsayeed1982 at yahoo dot com
2021-07-15  1:39 ` sherrixotyv29 at gmail dot com
2021-07-25  4:02 ` ampva300 at gmail dot com
2021-07-27  6:29 ` sherrixotyv29 at gmail dot com
2021-08-07  1:46 ` towingwpg at gmail dot com
2021-08-08  1:44 ` towingwpg at gmail dot com
2021-08-15  5:47 ` damienaloysius at gmail dot com
2021-08-18 13:52 ` jamesrogan59 at gmail dot com
2021-09-02 11:05 ` donipah907 at mtlcz dot com
2021-09-02 11:09 ` mark at klomp dot org
2021-09-05  7:34 ` kimolsun2020 at yahoo dot com
2021-09-06  9:06 ` focixujo at livinginsurance dot co.uk
2021-09-06  9:12 ` focixujo at livinginsurance dot co.uk
2021-09-10 19:38 ` mehmetgelisin at aol dot com [this message]
2021-09-26  2:42 ` spanksaucee01 at gmail dot com
2021-09-26  2:53 ` spanksaucee01 at gmail dot com
2021-09-26  2:59 ` spanksaucee01 at gmail dot com
2021-09-26  3:11 ` spanksaucee01 at gmail dot com
2021-09-26  3:17 ` spanksaucee01 at gmail dot com
2021-09-26  3:22 ` spanksaucee01 at gmail dot com
2021-09-26  3:28 ` spanksaucee01 at gmail dot com
2021-09-26  3:40 ` spanksaucee01 at gmail dot com
2021-09-29 13:24 ` schaumburgconcrete at gmail dot com
2021-10-06  3:06 ` jadinvestments1 at gmail dot com
2021-10-06  3:09 ` jadinvestments1 at gmail dot com
2021-10-09 11:00 ` gulsenenginar at aol dot com
2021-10-09 17:02 ` studiaviktor at gmail dot com
2021-10-17 11:56 ` ranktowin at gmail dot com
2021-10-18 19:58 ` ahmedsayeed1982 at hotmail dot com
2021-10-19  7:14 ` progonsaytu at gmail dot com
2021-10-24 10:02 ` glassmtech at ukr dot net
2021-10-27  1:29 ` windsordrywall at gmail dot com
2021-11-02  2:44 ` joanadavidson02 at gmail dot com
2021-11-04 18:08 ` ahbathroomremodel at gmail dot com
2021-11-07 21:13 ` treeservicesask at gmail dot com
2021-11-07 21:19 ` treeservicesask at gmail dot com
2021-11-18 13:58 ` drywallbrantford at protonmail dot com
2021-11-20  3:28 ` fullertonhomepainters at gmail dot com
2021-11-22  6:48 ` gexed96894 at keagenan dot com
2021-11-24 13:42 ` allen at rockvalleymarketing dot com
2021-11-24 17:02 ` cambridgeconcreting at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27194-4717-2teE2TFGS6@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).