[Bug symtab/27307] New: CUs counted twice by create_cus_from_debug_names_list

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=27307

            Bug ID: 27307
           Summary: CUs counted twice by create_cus_from_debug_names_list
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: symtab
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

I stumbled upon this code in create_addrmap_from_aranges:
...
  for (dwarf2_per_cu_data *per_cu : per_objfile->per_bfd->all_comp_units)
    {
      const auto insertpair
        = debug_info_offset_to_per_cu.emplace (per_cu->sect_off, per_cu);
      if (!insertpair.second)
        {
          warning (_("Section .debug_aranges in %s has duplicate "
                     "debug_info_offset %s, ignoring .debug_aranges."),
                   objfile_name (objfile), sect_offset_str (per_cu->sect_off));
          return;
        }
    }
...
and had difficulty understanding this.

The iteration is over all_comp_units, which has no relation to .debug_aranges,
so the warning does not make sense.

I tried to see if I could trigger it, so I added a "gdb_assert (false)" after
the warning.

I ran into the assert in test-cases gdb.dwarf2/clang-debug-names.exp and
gdb.dwarf2/clang-debug-names-2.exp.

Investigation showed that this is due to a bug in
create_cus_from_debug_names_list, which is fixed by:
...
@@ -5323,6 +5324,7 @@ create_cus_from_debug_names_list (dwarf2_per_bfd *per_bf
d,
          = create_cu_from_index_list (per_bfd, &section, is_dwz, sect_off, 0);
        per_bfd->all_comp_units.push_back (per_cu);
       }
+    return;
     }

   sect_offset sect_off_prev;
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.