public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug breakpoints/27313] Segfault in insert_catch_syscall
Date: Tue, 02 Feb 2021 07:32:13 +0000	[thread overview]
Message-ID: <bug-27313-4717-qTlRSV2sec@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27313-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=27313

--- Comment #1 from Tom de Vries <vries at gcc dot gnu.org> ---
In more detail:
...
Thread 1 "gdb" received signal SIGSEGV, Segmentation fault.
0x00000000004ce250 in insert_catch_syscall (bl=0x2133960)
    at /home/vries/gdb_versions/devel/src/gdb/break-catch-syscall.c:98
98                ++inf_data->syscalls_counts[iter];
...
and the segfault happens because:
...
(gdb) p iter
$1 = -1
(gdb) p inf_data->syscalls_counts
$2 = std::vector of length 0, capacity 0
...

Tentative patch:
...
diff --git a/gdb/break-catch-syscall.c b/gdb/break-catch-syscall.c
index 9772ac01497..7335377f899 100644
--- a/gdb/break-catch-syscall.c
+++ b/gdb/break-catch-syscall.c
@@ -390,6 +390,8 @@ catch_syscall_split_args (const char *arg)
       syscall_number = (int) strtol (cur_name, &endptr, 0);
       if (*endptr == '\0')
        {
+         if (syscall_number < 0)
+           error (_("Unknown syscall number '%d'."), syscall_number);
          get_syscall_by_number (gdbarch, syscall_number, &s);
          result.push_back (s.number);
        }
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2021-02-02  7:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02  7:08 [Bug breakpoints/27313] New: " vries at gcc dot gnu.org
2021-02-02  7:32 ` vries at gcc dot gnu.org [this message]
2021-02-02  8:14 ` [Bug breakpoints/27313] " vries at gcc dot gnu.org
2021-02-05 16:47 ` cvs-commit at gcc dot gnu.org
2021-02-05 16:48 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27313-4717-qTlRSV2sec@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).