[Bug fortran/27341] [dwarf-5] FAIL: gdb.fortran/function-calls.exp: p derived_types_and_module_calls::pass_cart_nd(c_nd)

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=27341

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
This is due to missing support for DW_TAG_generic_subrange in read_array_type.

So we have:
...
 <1><e1e>: Abbrev Number: 46 (DW_TAG_array_type)
    <e1f>   DW_AT_data_location: 2 byte block: 97 6    
(DW_OP_push_object_address; DW_OP_deref)
    <e22>   DW_AT_rank        : 6 byte block: 97 23 10 6 37 1a
    <e29>   DW_AT_type        : <0x139>
    <e2d>   DW_AT_sibling     : <0xe51>
 <2><e31>: Abbrev Number: 47 (DW_TAG_generic_subrange)
    <e32>   DW_AT_lower_bound : 8 byte block: 97 14 48 1e 23 20 22 6   
(DW_OP_push_object_address; DW_OP_over; DW_OP_lit24; DW_OP_mul;
DW_OP_plus_uconst: 32; DW_OP_plus; DW_OP_deref)
    <e3b>   DW_AT_upper_bound : 8 byte block: 97 14 48 1e 23 28 22 6   
(DW_OP_push_object_address; DW_OP_over; DW_OP_lit24; DW_OP_mul;
DW_OP_plus_uconst: 40; DW_OP_plus; DW_OP_deref)
    <e44>   DW_AT_byte_stride : 11 byte block: 97 14 48 1e 23 18 22 6 8 38 1e  
(DW_OP_push_object_address; DW_OP_over; DW_OP_lit24; DW_OP_mul;
DW_OP_plus_uconst: 24; DW_OP_plus; DW_OP_deref; DW_OP_const1u: 56; DW_OP_mul)
...

We start out in read_array_type with:
...
  type = element_type;
...
and then iterate over range_types to build up the type further.

But there are no DW_TAG_subrange_type children (only one
DW_TAG_generic_subrange), so range_types is empty, and type is kept unmodified.

Consequently, in set_die_type we apply the DW_AT_data_location to the
element_type (the one at 0x139) instead of to the newly build array type.

Then we try to print c_nd:
...
 <2><6e8>: Abbrev Number: 2 (DW_TAG_variable)
    <6e9>   DW_AT_name        : (indirect string, offset: 0x218): c_nd
    <6ed>   DW_AT_decl_file   : 1
    <6ed>   DW_AT_decl_line   : 198
    <6ee>   DW_AT_type        : <0x139>
    <6f2>   DW_AT_location    : 9 byte block: 3 e0 30 60 0 0 0 0 0     
(DW_OP_addr: 6030e0)
...
and find that the type has a data_location property, which when used gives
incorrect results.

-- 
You are receiving this mail because:
You are on the CC list for the bug.