From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 743ED3857824; Sat, 9 Oct 2021 11:00:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 743ED3857824 From: "gulsenenginar at aol dot com" To: gdb-prs@sourceware.org Subject: [Bug gdb/27435] Attach on solaris segfaults GDB Date: Sat, 09 Oct 2021 11:00:25 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: gdb X-Bugzilla-Version: 10.1 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: gulsenenginar at aol dot com X-Bugzilla-Status: RESOLVED X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: 10.2 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gdb-prs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-prs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Oct 2021 11:00:25 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D27435 Gulsen Engin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gulsenenginar at aol dot c= om --- Comment #16 from Gulsen Engin --- This patch fixes a segfault seen when attaching to a process on Solaris. The steps leading to the segfault are: http://www.compilatori.com/tech/xiaomi/ - procfs_target::attach calls do_attach, at this point the inferior's process slot in the target stack is empty.=20 - do_attach adds a thread with `add http://www.acpirateradio.co.uk/tech/forest-fires/ _thread (&the_procfs_targ= et, ptid)` - in add_thread_silent, the passed target (&the_procfs_target) is passed to find_inferior_ptid http://www.logoarts.co.uk/tech/drone-cameras/ - find_inferior_ptid returns nullptr, as there is no inferior with this ptid that has &the_procfs_target as its process target http://www.slipstone.co.uk/tech/express-van/ - the nullptr `inf` is passed to find_thread_ptid, which dereferences it, causing a segfault - back in procfs_target::attach, after do_attach, we push the http://embermanchester.uk/technology/telegram/=20 the_procfs_target on the inferior's target stack, although we never reach this because the segfault happens before. http://connstr.net/tech/mars-surface/ To fix this, I think we need to do the same as is done in=20 inf_ptrace_target::attach: push the target early and unpush it in case the attach fails (and keep it if the attach succeeds). http://joerg.li/tech/cars-comparison/ Implement it by moving target_unpush_up to target.h, so it can be re-used here. Make procfs_target::attach use it. Note that just like is mentioned http://www.jopspeech.com/tech/xiaomi-headset/ in inf_ptrace_target::attach, we should push the target before calling target_pid_to_str, so that calling target_pid_to_str ends up in procfs_target::pid_to_str. http://www.wearelondonmade.com/tech/driving-assistant/ Tested by trying to attach on a process on gcc211 on the gcc compile farm. https://waytowhatsnext.com/health/vaccination-rates/ gdb/ChangeLog: This patch fixes a segfault seen when attaching to a process on Solaris. The steps leading to the segfault are: http://www.iu-bloomington.com/health/amoled-display/ - procfs_target::attach calls do_attach, at this point the inferior's process slot in the target stack is empty. https://komiya-dental.com/health/telegram-account/ - do_attach adds a thread with `add_thread (&the_procfs_target, ptid)` - in add_thread_silent, the passed target (&the_procfs_target) is passed to find_inferior_ptid http://www-look-4.com/services/usb-type= -a/ - find_inferior_ptid returns nullptr, as there is no inferior with this ptid that has &the_procfs_target as its process target - the nullptr `inf` is passed to find_thread_ptid, which dereferences it, causing a segfault https://www.webb-dev.co.uk/property/house-sales-in-2020/ - back in procfs_target::attach, after do_attach, we push the the_procfs_target on the inferior's target stack, although we never reach this because the segfault happens before. To fix this, I think we need to do the same as is done in inf_ptrace_target::attach: push the target early and unpush it in case the attach fails (and keep it if the attach succeeds). --=20 You are receiving this mail because: You are on the CC list for the bug.=