public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug build/27535] amd64-linux-siginfo.c fails to compile after updating to glibc-2.33 headers
Date: Sat, 06 Mar 2021 17:58:33 +0000 [thread overview]
Message-ID: <bug-27535-4717-xxVbpGHTW5@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27535-4717@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=27535
--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-10-branch branch has been updated by Kevin Buettner
<kevinb@sourceware.org>:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=aebc4aa2ece0363c16cab5a546df05220227ec31
commit aebc4aa2ece0363c16cab5a546df05220227ec31
Author: Kevin Buettner <kevinb@redhat.com>
Date: Thu Feb 18 22:46:58 2021 -0700
amd64-linux-siginfo.c: Adjust include order to avoid gnulib error
On Fedora rawhide, after updating to glibc-2.33, I'm seeing the
following build failure:
CXX nat/amd64-linux-siginfo.o
In file included from /usr/include/bits/sigstksz.h:24,
from /usr/include/signal.h:315,
from ../gnulib/import/signal.h:52,
from
/ironwood1/sourceware-git/rawhide-gnulib/bld/../../worktree-gnulib/gdbserver/../gdb/nat/amd64-linux-siginfo.c:20:
../gnulib/import/unistd.h:663:3: error: #error "Please include config.h
first."
663 | #error "Please include config.h first."
| ^~~~~
glibc-2.33 has changed signal.h to now include <bits/sigstksz.h> which,
in turn, includes <unistd.h>. For a gdb build, this causes the gnulib
version of unistd.h to be pulled in first. The build failure shown
above happens because gnulib's config.h has not been included before
the include of <signal.h>.
The fix is simple - we just rearrange the order of the header file
includes to make sure that gdbsupport/commondefs.h is included before
attempting to include signal.h. Note that gdbsupport/commondefs.h
includes <gnulib/config.h>.
Build and regression tested on Fedora 33. On Fedora rawhide, GDB
builds again.
gdb/ChangeLog:
PR build/27535
* nat/amd64-linux-siginfo.c: Include "gdbsupport/common-defs.h"
(which in turn includes <gnulib/config.h>) before include
of <signal.h>.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2021-03-06 17:58 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 16:25 [Bug build/27535] New: " kevinb at redhat dot com
2021-03-06 16:25 ` [Bug build/27535] " kevinb at redhat dot com
2021-03-06 16:26 ` kevinb at redhat dot com
2021-03-06 17:58 ` cvs-commit at gcc dot gnu.org [this message]
2021-03-07 4:44 ` brobecker at gnat dot com
2021-03-07 6:23 ` kevinb at redhat dot com
2021-06-27 17:42 ` ahmedsayeed1982 at yahoo dot com
2021-07-15 7:39 ` lennordocdoc0921 at gmail dot com
2021-08-02 4:15 ` lennordocdoc0921 at gmail dot com
2021-08-19 6:01 ` ucelsanicin at yahoo dot com
2021-09-02 11:07 ` donipah907 at mtlcz dot com
2021-09-02 11:11 ` mark at klomp dot org
2021-09-06 9:09 ` focixujo at livinginsurance dot co.uk
2021-09-10 19:39 ` mehmetgelisin at aol dot com
2021-09-17 12:15 ` richard.aidoo at yahoo dot co.uk
2021-09-22 10:11 ` diheto5497 at secbuf dot com
2021-09-26 13:31 ` tes.vik1986 at gmail dot com
2021-09-29 15:45 ` seolab.backlinks at gmail dot com
2021-10-07 2:33 ` kasylinks at yahoo dot com
2021-10-09 11:00 ` gulsenenginar at aol dot com
2021-10-10 16:11 ` oficaj3 at gmail dot com
2021-10-19 7:13 ` progonsaytu at gmail dot com
2021-10-23 13:47 ` fiteva5725 at bomoads dot com
2021-10-24 10:01 ` glassmtech at ukr dot net
2021-10-29 12:04 ` sanantoniotileinstallation at gmail dot com
2021-10-30 9:28 ` aisonwrnerxbg15 at gmail dot com
2021-10-31 6:51 ` allowable2001ballmer at gmail dot com
2021-11-01 14:08 ` aleneuuiwb15 at gmail dot com
2021-11-02 11:17 ` antiguans2000antiguans at gmail dot com
2021-11-03 7:54 ` barronwbs85 at gmail dot com
2021-11-04 9:22 ` bahamianiridescent at gmail dot com
2021-11-05 14:19 ` boscoblsxv14 at gmail dot com
2021-11-06 1:45 ` bpbniche at gmail dot com
2021-11-06 11:19 ` great1971greatratt at gmail dot com
2021-11-06 21:12 ` paneki8601 at dukeoo dot com
2021-11-07 12:00 ` great1971greatratt at gmail dot com
2021-11-07 12:10 ` great1971greatratt at gmail dot com
2021-11-08 8:29 ` richardshodges7 at gmail dot com
2021-11-09 11:46 ` johnsjvi95 at gmail dot com
2021-11-11 14:14 ` schaeferkkf25 at gmail dot com
2021-11-12 11:42 ` shannanalt11 at gmail dot com
2021-11-13 17:49 ` raidoo8585 at gmail dot com
2021-11-13 18:06 ` bpbniche at gmail dot com
2021-11-13 19:33 ` tesaso8237 at funboxcn dot com
2021-11-14 3:45 ` brickpavingcl at gmail dot com
2021-11-16 19:04 ` xecana8007 at funboxcn dot com
2021-11-16 19:08 ` xecana8007 at funboxcn dot com
2021-11-16 19:12 ` xecana8007 at funboxcn dot com
2021-11-16 19:15 ` xecana8007 at funboxcn dot com
2021-11-19 6:39 ` aslanelli50 at gmail dot com
2021-11-22 1:02 ` zacmanken at gmail dot com
2021-11-22 1:04 ` zacmanken at gmail dot com
2021-11-22 7:39 ` gexed96894 at keagenan dot com
2021-11-24 10:33 ` nicolas666 at netcourrier dot com
2021-11-25 3:39 ` bpbniche at gmail dot com
2022-01-10 1:45 ` bpbniche at gmail dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-27535-4717-xxVbpGHTW5@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=gdb-prs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).