public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug build/27536] aarch64-linux-hw-point.c fails to compile after updating to glibc-2.33
Date: Sat, 06 Mar 2021 17:58:39 +0000	[thread overview]
Message-ID: <bug-27536-4717-eJARrzsIZW@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27536-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=27536

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-10-branch branch has been updated by Kevin Buettner
<kevinb@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=4cacb6939378ef824b37140886e7ea31c33f14c3

commit 4cacb6939378ef824b37140886e7ea31c33f14c3
Author: Kevin Buettner <kevinb@redhat.com>
Date:   Wed Feb 24 11:48:04 2021 -0700

    Fix aarch64-linux-hw-point.c build problem

    Due to a recent glibc header file change, the file
    nat/aarch64-linux-hw-point.c no longer builds on Fedora rawhide.

    An enum for PTRACE_SYSEMU is now provided by <sys/ptrace.h>.  In the
    past, PTRACE_SYSEMU was defined only in <asm/ptrace.h>.  This is
    what it looks like...

    In <asm/ptrace.h>:

     #define PTRACE_SYSEMU            31

    In <sys/ptrace.h>:

    enum __ptrace_request
    {
      ...
      PTRACE_SYSEMU = 31,
     #define PT_SYSEMU PTRACE_SYSEMU

      ...
    }

    When <asm/ptrace.h> and <sys/ptrace.h> are both included in a source
    file, we run into the following build problem when the former is
    included before the latter:

    In file included from nat/aarch64-linux-hw-point.c:26:
    /usr/include/sys/ptrace.h:86:3: error: expected identifier before numeric
constant
       86 |   PTRACE_SYSEMU = 31,
          |   ^~~~~~~~~~~~~

    (There are more errors after this one too.)

    The file builds without error when <asm/ptrace.h> is included after
    <sys/ptrace.h>.  I found that this is already done in
    nat/aarch64-sve-linux-ptrace.h (which is included by
    nat/aarch64-linux-ptrace.c).

    I've tested this change on Fedora rawhide and Fedora 33, both
    running on an aarch64 machine.

    gdb/ChangeLog:

            PR build/27536
            * nat/aarch64-linux-hw-point.c: Include <asm/ptrace.h> after
            <sys/ptrace.h>.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-03-06 17:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-06 16:35 [Bug build/27536] New: " kevinb at redhat dot com
2021-03-06 16:42 ` [Bug build/27536] " kevinb at redhat dot com
2021-03-06 17:58 ` cvs-commit at gcc dot gnu.org [this message]
2021-03-07  4:43 ` brobecker at gnat dot com
2021-03-07  6:25 ` kevinb at redhat dot com
2021-06-27 17:45 ` ahmedsayeed1982 at yahoo dot com
2021-09-02 11:06 ` donipah907 at mtlcz dot com
2021-09-02 11:12 ` mark at klomp dot org
2021-09-05  7:34 ` kimolsun2020 at yahoo dot com
2021-09-06  9:08 ` focixujo at livinginsurance dot co.uk
2021-09-10 19:38 ` mehmetgelisin at aol dot com
2021-09-22 10:19 ` diheto5497 at secbuf dot com
2021-09-22 13:03 ` sam at gentoo dot org
2021-09-26 13:31 ` tes.vik1986 at gmail dot com
2021-10-09 11:01 ` gulsenenginar at aol dot com
2021-10-09 17:43 ` svitvitraga at gmail dot com
2021-10-18 19:57 ` ahmedsayeed1982 at hotmail dot com
2021-10-19  7:13 ` progonsaytu at gmail dot com
2021-10-24 10:01 ` glassmtech at ukr dot net
2021-11-13 19:34 ` tesaso8237 at funboxcn dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-27536-4717-eJARrzsIZW@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).