From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id A138A389246B; Tue,  6 Apr 2021 08:40:21 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A138A389246B
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tui/27680] ui-style.c:243: internal-error: bool
 ui_file_style::parse(const char*, size_t*): Assertion `match == 0' failed.'
Date: Tue, 06 Apr 2021 08:40:21 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: tui
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-27680-4717-8MfVLx2EcF@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-27680-4717@http.sourceware.org/bugzilla/>
References: <bug-27680-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2021 08:40:21 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27680

--- Comment #10 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot g=
nu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dd811a7cf74fa=
8523f67a13c0527b27f4954e9ae1

commit d811a7cf74fa8523f67a13c0527b27f4954e9ae1
Author: Tom de Vries <tdevries@suse.de>
Date:   Tue Apr 6 10:40:11 2021 +0200

    [gdb/tui] Fix len_without_escapes in tui-disasm.c

    On openSUSE Tumbleweed I run into:
    ...
    FAIL: gdb.tui/basic.exp: asm window shows main
    ERROR: invalid command name "_csi_L"
    ...

    Using a minimal example, we get:
    ...
    $ gdb -q outputs/gdb.tui/basic/basic -ex "tui enable" -ex "layout asm"
    <TUI output>
    src/gdb/ui-style.c:243: internal-error: bool \
      ui_file_style::parse(const char*, size_t*): Assertion `match =3D=3D 0'
failed.
    ...

    The problem is in len_without_escapes, where we detect the start of an
escape
    sequence, but then pass ptr to style.parse while ptr no longer points to
the
    escape due to the ptr++ in the while condition:
    ...
      while ((c =3D *ptr++) !=3D '\0')
         {
          if (c =3D=3D '\033')
            {
              ui_file_style style;
              size_t n_read;
              if (style.parse (ptr, &n_read))
    ...

    Fix this by removing the ++ in the while condition, and adding ptr++ in=
 the
    loop body where appropriate.

    Tested on x86_64-linux.

    gdb/ChangeLog:

    2021-04-06  Tom de Vries  <tdevries@suse.de>

            PR tui/27680
            * tui/tui-disasm.c (len_without_escapes): Pass ptr pointing at
escape
            to style.parse.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=