From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 021463857816; Thu,  1 Apr 2021 13:44:37 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 021463857816
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug tui/27680] ui-style.c:243: internal-error: bool
 ui_file_style::parse(const char*, size_t*): Assertion `match == 0' failed.'
Date: Thu, 01 Apr 2021 13:44:37 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: tui
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vries at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-27680-4717-FsyswveiJw@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-27680-4717@http.sourceware.org/bugzilla/>
References: <bug-27680-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Apr 2021 13:44:38 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27680

--- Comment #8 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom Tromey from comment #7)
> The code in the loop isn't expecting the ++ in the loop header.
> The else clause also has this same bug:
>=20
> 	  else
> 	    {
> 	      /* Shouldn't happen, but just skip the ESC if it somehow
> 		 does.  */
> 	      ++ptr;
> 	    }

OK, then:
...
diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c
index 65b300cb008..163552aede4 100644
--- a/gdb/tui/tui-disasm.c
+++ b/gdb/tui/tui-disasm.c
@@ -61,7 +61,7 @@ len_without_escapes (const std::string &str)
   const char *ptr =3D str.c_str ();
   char c;

-  while ((c =3D *ptr++) !=3D '\0')
+  while ((c =3D *ptr) !=3D '\0')
     {
       if (c =3D=3D '\033')
        {
@@ -77,7 +77,10 @@ len_without_escapes (const std::string &str)
            }
        }
       else
-       ++len;
+       {
+         ++len;
+         ++ptr;
+       }
     }
   return len;
 }
...

--=20
You are receiving this mail because:
You are on the CC list for the bug.=