From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 311813948AA5; Thu,  8 Apr 2021 13:10:50 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 311813948AA5
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/27681] FAIL: gdb.base/help.exp: apropos \(print[^[
 bsiedf\".-]\) (timeout)
Date: Thu, 08 Apr 2021 13:10:49 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: gdb
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tromey at sourceware dot org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-27681-4717-uvkVeZSiuR@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-27681-4717@http.sourceware.org/bugzilla/>
References: <bug-27681-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Apr 2021 13:10:50 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27681

--- Comment #24 from Tom Tromey <tromey at sourceware dot org> ---
> from the same implementation.  (Linking statically against libiberty or
> gnulib
> would ensure this, as would directly linking in regex.o, but linking
> dynamically
> against libc and pcre2-posix would not).

libiberty renames the symbols to avoid clashing, which is why that
USE_INCLUDED_REGEX / xregex.h include stuff matters.  It prepends
an "x":

murgatroyd. pwd
/home/tromey/gdb/build/libiberty
murgatroyd. nm regex.o|grep regfree
00000000000063d0 T xregfree

I think there are a few routes forward:

1. Change the code to conform to POSIX.  Fine by me.

2. Change the code to always use libiberty.  This requires understanding
   why the alternative was ever made possible.

Option 2 has this mild benefit around avoiding allocations, if we want
to pursue it.

I tend to doubt that regex performance is at all important to gdb,
so I wouldn't worry about whether pcre is better or stuff like that.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=