From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 7F8E1385E017; Fri, 9 Apr 2021 09:31:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7F8E1385E017 From: "vries at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug corefiles/27689] FAIL: gdb.base/gcore-tls-pie.exp: x/i $pc Date: Fri, 09 Apr 2021 09:31:11 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: corefiles X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: vries at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gdb-prs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-prs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2021 09:31:11 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D27689 --- Comment #9 from Tom de Vries --- (In reply to Tom de Vries from comment #8) > As for gdb, the patch I was testing was: > ... > diff --git a/bfd/elf.c b/bfd/elf.c > index 276fa14c0dd..8f245d59fef 100644 > --- a/bfd/elf.c > +++ b/bfd/elf.c > @@ -12160,6 +12160,13 @@ elf_parse_notes (bfd *abfd, char *buf, size_t si= ze, > file > _ptr offset, > if (in.namesz > buf - in.namedata + size) > return false; >=20=20 > + if (in.namesz =3D=3D 0) > + { > + /* Assume it's padding, try again. */ > + p +=3D 4; > + continue; > + } > +=20=20=20=20=20=20 > in.descsz =3D H_GET_32 (abfd, xnp->descsz); > in.descdata =3D p + ELF_NOTE_DESC_OFFSET (in.namesz, align); > in.descpos =3D offset + (in.descdata - buf); > ... >=20 > But having verified that the test passes with eu-readelf without this pat= ch, > I'm not sure if it will turn out to be necessary. >=20 > So, we'll just have to retest after the strip PR has been fixed. Though still the patch might be worth submitting. --=20 You are receiving this mail because: You are on the CC list for the bug.=