public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug corefiles/27689] FAIL: gdb.base/gcore-tls-pie.exp: x/i $pc Date: Wed, 07 Apr 2021 13:39:12 +0000 [thread overview] Message-ID: <bug-27689-4717-GUfN00fUYc@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-27689-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=27689 Tom de Vries <vries at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27708 --- Comment #8 from Tom de Vries <vries at gcc dot gnu.org> --- As for gdb, the patch I was testing was: ... diff --git a/bfd/elf.c b/bfd/elf.c index 276fa14c0dd..8f245d59fef 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -12160,6 +12160,13 @@ elf_parse_notes (bfd *abfd, char *buf, size_t size, file _ptr offset, if (in.namesz > buf - in.namedata + size) return false; + if (in.namesz == 0) + { + /* Assume it's padding, try again. */ + p += 4; + continue; + } + in.descsz = H_GET_32 (abfd, xnp->descsz); in.descdata = p + ELF_NOTE_DESC_OFFSET (in.namesz, align); in.descpos = offset + (in.descdata - buf); ... But having verified that the test passes with eu-readelf without this patch, I'm not sure if it will turn out to be necessary. So, we'll just have to retest after the strip PR has been fixed. Referenced Bugs: https://sourceware.org/bugzilla/show_bug.cgi?id=27708 [Bug 27708] strip mishandles padding between notes -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2021-04-07 13:39 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-02 15:36 [Bug corefiles/27689] New: " vries at gcc dot gnu.org 2021-04-05 14:17 ` [Bug corefiles/27689] " vries at gcc dot gnu.org 2021-04-05 14:21 ` vries at gcc dot gnu.org 2021-04-05 14:27 ` vries at gcc dot gnu.org 2021-04-05 18:40 ` vries at gcc dot gnu.org 2021-04-07 12:56 ` vries at gcc dot gnu.org 2021-04-07 13:07 ` vries at gcc dot gnu.org 2021-04-07 13:22 ` vries at gcc dot gnu.org 2021-04-07 13:39 ` vries at gcc dot gnu.org [this message] 2021-04-09 9:31 ` vries at gcc dot gnu.org 2024-02-16 2:54 ` amodra at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-27689-4717-GUfN00fUYc@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).