[Bug gdb/27710] remote-notif.c:113: internal-error: void remote_async_get_pending_events_handler(gdb_client_data): Assertion `target_is_non_stop_p ()' failed

["simark at simark dot ca" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=27710

--- Comment #19 from Simon Marchi <simark at simark dot ca> ---
I don't really understand this supposed separation of concerns between remote.c
and remote-notif.c.  They both know about each other: remote_target (well,
remote_state) uses remote_notif_state, and remote_notif_state (and
notif_client) only works with remote_target as its user.  Anyway.

To avoid all this churn, I'd be fine with a new util function
"remote_target_is_non_stop", implemented in remote.c, like:

bool
remote_target_is_non_stop_p (remote_target *t)
{
  scoped_restore_current_thread restore_thread;
  switch_to_target_no_thread (t);

  return target_is_non_stop_p ();
}

You could then use

gdb_assert (remote_target_is_non_stop_p (remote_target))

in remote-notif.c.

If / when target_is_non_stop_p becomes a method on target_ops and hopefully
independent from the current context, it could be simplified to:

bool
remote_target_is_non_stop_p (remote_target *t)
{
  return t->is_non_stop_p ();
}

-- 
You are receiving this mail because:
You are on the CC list for the bug.