From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 47ADA398B870; Thu, 22 Apr 2021 15:01:05 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 47ADA398B870
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug remote/27710] remote-notif.c:113: internal-error: void
 remote_async_get_pending_events_handler(gdb_client_data): Assertion
 `target_is_non_stop_p ()' failed
Date: Thu, 22 Apr 2021 15:01:05 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: remote
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-27710-4717-d5EuLeDvA0@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-27710-4717@http.sourceware.org/bugzilla/>
References: <bug-27710-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Apr 2021 15:01:05 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27710

--- Comment #21 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot g=
nu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3Dc39ebbf43faa=
932a6860fd9c3607503641659898

commit c39ebbf43faa932a6860fd9c3607503641659898
Author: Tom de Vries <tdevries@suse.de>
Date:   Thu Apr 22 17:01:00 2021 +0200

    [gdb] Fix assert in remote_async_get_pending_events_handler

    Occassionally I run into the following assert:
    ...
    (gdb) PASS: gdb.multi/multi-target-continue.exp: inferior 5
    Remote debugging from host ::1, port 49990^M
    Process multi-target-continue created; pid =3D 31241^M
    src/gdb/remote-notif.c:113: internal-error: \
      void remote_async_get_pending_events_handler(gdb_client_data): \
      Assertion `target_is_non_stop_p ()' failed.^M
    ...

    The assert checks target_is_non_stop_p, which is related to the current
    target.

    Fix this by changing the assert such that it checks non-stopness relate=
d to
    the event it's handling.

    Tested on x86_64-linux.

    gdb/ChangeLog:

    2021-04-22  Simon Marchi  <simon.marchi@polymtl.ca>
                Tom de Vries  <tdevries@suse.de>

            PR remote/27710
            * remote.c (remote_target_is_non_stop_p): New function.
            * remote.h (remote_target_is_non_stop_p): Declare.
            * remote-notif.c (remote_async_get_pending_events_handler): Fix
assert
            to check non-stopness using notif_state->remote rather current
target.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=