[Bug gdb/27743] Internal error psymtab.c

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=27743

--- Comment #24 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-10-branch branch has been updated by Tom Tromey
<tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=e7d77ce0c408e7019f9885b8be64c9cdb46dd312

commit e7d77ce0c408e7019f9885b8be64c9cdb46dd312
Author: Tom Tromey <tromey@adacore.com>
Date:   Fri Apr 23 11:28:48 2021 -0600

    Fix crash when expanding partial symtabs with DW_TAG_imported_unit

    PR gdb/27743 points out a gdb crash when expanding partial symtabs,
    where one of the compilation units uses DW_TAG_imported_unit.

    The bug is that partial_map_expand_apply expects only to be called for
    the outermost psymtab.  However, filename searching doesn't (and
    probably shouldn't) guarantee this.  The fix is to walk upward to find
    the outermost CU.

    A new test case is included.  It is mostly copied from other test
    cases, which really sped up the effort.

    This bug does not occur on trunk.  There,
    psym_map_symtabs_matching_filename is gone, replaced by
    psymbol_functions::expand_symtabs_matching.  When this find a match,
    it calls psymtab_to_symtab, which does this same upward walk.

    Tested on x86-64 Fedora 32.

    I propose checking in this patch on the gdb-10 branch, and just the
    new test case on trunk.

    gdb/ChangeLog
    2021-04-23  Tom Tromey  <tromey@adacore.com>

            PR gdb/27743:
            * psymtab.c (partial_map_expand_apply): Expand outermost psymtab.

    gdb/testsuite/ChangeLog
    2021-04-23  Tom Tromey  <tromey@adacore.com>

            PR gdb/27743:
            * gdb.dwarf2/imported-unit-bp.exp: New file.
            * gdb.dwarf2/imported-unit-bp-main.c: New file.
            * gdb.dwarf2/imported-unit-bp-alt.c: New file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.