[Bug gdb/27780] not report warning when set a breakpoint at invalid address for arm64

["wenyan.xin at windriver dot com" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=27780

--- Comment #1 from wenyan.xin at windriver dot com ---
when set a 0 address breakpoint, our Gdb Server send "E01" to gdb client, and
the function remote_target::insert_breakpoint () in fremote.c file return -1;

In file breakpoint.c the function insert_bp_location() says that it returns -1
for failure, but in this case it return 0;


Any error messages are printed to TMP_ERROR_STREAM; and
DISABLED_BREAKS, and HW_BREAKPOINT_ERROR are used to report problems.
Returns 0 for success, 1 if the bp_location type is not supported or
-1 for failure.

      if (bp_excpt.reason != 0)
        {
          /* Can't set the breakpoint.  */

          /* In some cases, we might not be able to insert a
             breakpoint in a shared library that has already been
             removed, but we have not yet processed the shlib unload
             event.  Unfortunately, some targets that implement
             breakpoint insertion themselves can't tell why the
             breakpoint insertion failed (e.g., the remote target
             doesn't define error codes), so we must treat generic
             errors as memory errors.  */
          if (bp_excpt.reason == RETURN_ERROR
              && (bp_excpt.error == GENERIC_ERROR
                  || bp_excpt.error == MEMORY_ERROR)
              && bl->loc_type == bp_loc_software_breakpoint
              && (solib_name_from_address (bl->pspace, bl->address)
                  || shared_objfile_contains_address_p (bl->pspace,
                                                        bl->address)))
            {
              /* See also: disable_breakpoints_in_shlibs.  */
              bl->shlib_disabled = 1;
              gdb::observers::breakpoint_modified.notify (bl->owner);
              if (!*disabled_breaks)
                {
                  fprintf_unfiltered (tmp_error_stream, 
                                      "Cannot insert breakpoint %d.\n", 
                                      bl->owner->number);
                  fprintf_unfiltered (tmp_error_stream, 
                                      "Temporarily disabling shared "
                                      "library breakpoints:\n");
                }
              *disabled_breaks = 1;
              fprintf_unfiltered (tmp_error_stream,
                                  "breakpoint #%d\n", bl->owner->number);
              return 0;    // is this case it return from here, then this issue
happened.
            }

-- 
You are receiving this mail because:
You are on the CC list for the bug.