public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug cli/27813] FAIL: gdb.linespec/cpcompletion.exp: incomplete-scope-colon: tab complete "b cpls.cc:'ns_incomplete_scope_colon_test::i" (clearing input line) (timeout) Date: Wed, 07 Jun 2023 12:57:40 +0000 [thread overview] Message-ID: <bug-27813-4717-xdGsaHHtIZ@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-27813-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=27813 --- Comment #16 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Tom de Vries <vries@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=a6bc87757c85035a7cbb44da0706084043af68d1 commit a6bc87757c85035a7cbb44da0706084043af68d1 Author: Tom de Vries <tdevries@suse.de> Date: Wed Jun 7 14:57:40 2023 +0200 [gdb/cli] Handle pending ^C after rl_callback_read_char for readline 7 In commit faf01aee1d0 ("[gdb] Handle pending ^C after rl_callback_read_char") we handled a problem (described in detail in that commit) for readline >= 8 using public readline functions rl_pending_signal and rl_check_signals. For readline 7 (note that we require at least readline 7 so there's no need to worry about readline 6), there was no fix though, because rl_check_signals was not available. Fix this by instead using the private readline function _rl_signal_handler. There is precedent for using private readline variables and functions, but it's something we want to get rid of (PR build/10723). Nevertheless, I think we can allow this specific instance because it's not used when building against readline >= 8. [ In the meanwhile, a fix was committed in the devel branch of the readline repo, contained in commit 8d0c439 ("rollup of changes since readline-8.2"), first proposed here ( https://lists.gnu.org/archive/html/bug-readline/2022-10/msg00008.html ). ] Tested on x86_64-linux, against system readline 7.0 on openSUSE Leap 15.4. PR cli/27813 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=27813 -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2023-06-07 12:57 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-03 13:28 [Bug gdb/27813] New: " vries at gcc dot gnu.org 2021-05-03 23:21 ` [Bug gdb/27813] " vries at gcc dot gnu.org 2022-04-06 21:05 ` vries at gcc dot gnu.org 2022-04-06 21:17 ` simark at simark dot ca 2022-09-12 9:02 ` luis.machado at arm dot com 2022-09-12 14:45 ` vries at gcc dot gnu.org 2022-09-12 15:02 ` vries at gcc dot gnu.org 2022-09-12 15:48 ` vries at gcc dot gnu.org 2022-09-13 6:57 ` vries at gcc dot gnu.org 2022-09-13 7:40 ` vries at gcc dot gnu.org 2022-09-13 7:41 ` vries at gcc dot gnu.org 2022-09-13 12:57 ` vries at gcc dot gnu.org 2022-09-16 13:58 ` vries at gcc dot gnu.org 2023-05-24 9:20 ` [Bug cli/27813] " vries at gcc dot gnu.org 2023-05-24 9:41 ` vries at gcc dot gnu.org 2023-05-24 9:42 ` vries at gcc dot gnu.org 2023-05-24 10:42 ` vries at gcc dot gnu.org 2023-06-07 12:57 ` cvs-commit at gcc dot gnu.org [this message] 2023-06-14 5:51 ` vries at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-27813-4717-xdGsaHHtIZ@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).