public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/27937] Performance regression of 8% due to assert in dwarf/read/attribute.h
Date: Fri, 04 Jun 2021 15:28:30 +0000 [thread overview]
Message-ID: <bug-27937-4717-HfGwcEE6aQ@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-27937-4717@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=27937
--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to Tom Tromey from comment #2)
> (In reply to Simon Marchi from comment #1)
> > I sometimes wonder if we should have a gdb_assert version that is only
> > enabled in development builds, that we could use in very hot paths like this
> > one, without affecting performance of production builds.
>
> Seems reasonable to me, and especially for this assert, which just introduces
> a new check that didn't even exist in earlier versions. That is, removing
> the assert or having it not run in production is identical to the status quo
> ante.
After writing this, I remembered that Pedro hadn't like the
"asan-by-default" approach, because it meant that you had to
do a special build to do performance testing.
So maybe we need to have opt-in development asserts.
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2021-06-04 15:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 8:30 [Bug symtab/27937] New: " vries at gcc dot gnu.org
2021-06-01 8:30 ` [Bug symtab/27937] " vries at gcc dot gnu.org
2021-06-01 15:26 ` ssbssa at sourceware dot org
2021-06-01 16:36 ` simark at simark dot ca
2021-06-01 21:12 ` tromey at sourceware dot org
2021-06-04 15:28 ` tromey at sourceware dot org [this message]
2022-04-15 13:31 ` tromey at sourceware dot org
2022-04-15 13:58 ` tromey at sourceware dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-27937-4717-HfGwcEE6aQ@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=gdb-prs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).