From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 8EB0B395C80C; Tue,  1 Jun 2021 21:12:29 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8EB0B395C80C
From: "tromey at sourceware dot org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/27937] Performance regression of 8% due to assert in
 dwarf/read/attribute.h
Date: Tue, 01 Jun 2021 21:12:29 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gdb
X-Bugzilla-Component: symtab
X-Bugzilla-Version: HEAD
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tromey at sourceware dot org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-27937-4717-x6kt7XlHGR@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-27937-4717@http.sourceware.org/bugzilla/>
References: <bug-27937-4717@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gdb-prs@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-prs mailing list <gdb-prs.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-prs/>
List-Help: <mailto:gdb-prs-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-prs>,
 <mailto:gdb-prs-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Jun 2021 21:12:29 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27937

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
(In reply to Simon Marchi from comment #1)
> I sometimes wonder if we should have a gdb_assert version that is only
> enabled in development builds, that we could use in very hot paths like t=
his
> one, without affecting performance of production builds.

Seems reasonable to me, and especially for this assert, which just introduc=
es
a new check that didn't even exist in earlier versions.  That is, removing
the assert or having it not run in production is identical to the status quo
ante.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=