From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 660A93857731; Fri, 6 Oct 2023 12:08:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 660A93857731 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1696594122; bh=xyPV77jNavkoyESinKizYPKn+Jdh3pDhmGV14JMJQCQ=; h=From:To:Subject:Date:In-Reply-To:References:From; b=spIjRUnZ9xo5nUY396Un3CCbjR+j7mc5K5zJ342ZMgJFp3nwAmauonLlv4eO3+aTI EYpGYfn+pW3eUPbnSlkMs0QSezC+lhPbFuQHugtfXk0uWKRzN8p6/jPoVmLHx/elb/ dCPM+F23kijyspncewQuiXtoPDGzjwCJqBmKDpjs= From: "cvs-commit at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug gdb/27989] gdb.base/args.exp fails with native-extended-gdbserver board Date: Fri, 06 Oct 2023 12:08:41 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: gdb X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://sourceware.org/bugzilla/show_bug.cgi?id=3D27989 --- Comment #5 from cvs-commit at gcc dot gnu.org --- The master branch has been updated by Andrew Burgess : https://sourceware.org/git/gitweb.cgi?p=3Dbinutils-gdb.git;h=3D67e6945b7e3a= 5c1577d19b9d83ee9be86c0a8424 commit 67e6945b7e3a5c1577d19b9d83ee9be86c0a8424 Author: Andrew Burgess Date: Wed Sep 27 17:54:15 2023 +0100 gdbserver: handle newlines in inferior arguments Similarly to how single quotes were mishandled, which was fixed two commits ago, this commit fixes handling of newlines in arguments passed to gdbserver. We already had a test that covered this, gdb.base/args.exp, which, when run with the native-extended-gdbserver board contained several KFAIL covering this situation. In this commit I remove the unnecessary, attempt to quote incoming newlines within arguments, and do some minimal cleanup of the related code. There is additional cleanup that can be done, but I'm leaving that for the next commit. Then I've removed the KFAIL from the test case, and performed some minimal cleanup there too. After this commit the gdb.base/args.exp is 100% passing with the native-extended-gdbserver board file. During review I was pointed to this older series: =20=20=20=20=20 https://inbox.sourceware.org/gdb-patches/20211022071933.3478427-1-m.weghorn= @posteo.de/ which also includes this fix as part of a larger set of changes. I'm giving a Co-Authored-By credit to the author of that original series. I believe this smaller fix brings some benefits on its own, though the original series does offer additional improvements. Once this is merged I'll take a look at rebasing and resubmitting the original serie= s. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D27989 Co-Authored-By: Michael Weghorn Approved-By: Tom Tromey --=20 You are receiving this mail because: You are on the CC list for the bug.=