[Bug mi/28076] [regression] Cannot remove condition from breakpoint from MI

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=28076

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The gdb-11-branch branch has been updated by Tankut Baris Aktemur
<aktemur@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=86271cfa326990fc05b5abada2831da161c0bf4b

commit 86271cfa326990fc05b5abada2831da161c0bf4b
Author: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Date:   Mon Jul 26 08:25:03 2021 +0200

    gdb/mi: handle no condition argument case for -break-condition

    As reported in PR gdb/28076 [1], passing no condition argument to the
    -break-condition command (e.g.: "-break-condition 2") should clear the
    condition for breakpoint 2, just like CLI's "condition 2", but instead
    an error message is returned:

      ^error,msg="-break-condition: Missing the <number> and/or <expr>
argument"

    The current implementation of the -break-condition command's argument
    handling (79aabb7308c "gdb/mi: add a '--force' flag to the
    '-break-condition' command") was done according to the documentation,
    where the condition argument seemed mandatory.  However, the
    -break-condition command originally (i.e. before the 79aabb7308c
    patch) used the CLI's "cond" command, and back then not passing a
    condition argument was clearing out the condition.  So, this is a
    regression in terms of the behavior.

    Fix the argument handling of the -break-condition command to allow not
    having a condition argument, and also update the document to make the
    behavior clear.  Also add test cases to test the scenarios which were
    previously not covered.

    [1] https://sourceware.org/bugzilla/show_bug.cgi?id=28076

    gdb/ChangeLog:
    2021-07-26  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>

            PR gdb/28076
            * mi/mi-cmd-break.c (mi_cmd_break_condition): Handle the case
            of having no condition argument.

    gdb/doc/ChangeLog:
    2021-07-26  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>

            PR gdb/28076
            * gdb.texinfo (GDB/MI Breakpoint Commands): Mention clearing
            the condition in the -break-condition command.

    gdb/testsuite/ChangeLog:
    2021-07-26  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>

            PR gdb/28076
            * gdb.mi/mi-break.exp: Add more tests to check clearing the
            breakpoint condition.

-- 
You are receiving this mail because:
You are on the CC list for the bug.