public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "usaonmonday at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug varobj/28131] Segfault in gdbpy_enter_varobj::gdbpy_enter_varobj when debugging in VS Code
Date: Sat, 24 Jul 2021 23:53:52 +0000	[thread overview]
Message-ID: <bug-28131-4717-bmxmr0jMV0@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28131-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28131

Andrey Sotnikov <usaonmonday at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org

--- Comment #1 from Andrey Sotnikov <usaonmonday at gmail dot com> ---
I ran a quick binary search and found the culprit commit:

SHA-1: 24fd95b4cd40f0108299c02f31f2d2a129f83769

* Change varobj_dynamic::child_iter to unique_ptr

This changes varobj_dynamic::child_iter to be a unique_ptr, removing
some manual management.

gdb/ChangeLog
2020-12-11  Tom Tromey  <tom@tromey.com>

        * varobj.c (struct varobj_dynamic) <child_iter>: Now unique_ptr.
        (varobj_get_iterator): Return unique_ptr.
        (update_dynamic_varobj_children, install_visualizer)
        (varobj::~varobj): Update.
        * python/python-internal.h (py_varobj_get_iterator): Return
        unique_ptr.
        * python/py-varobj.c (py_varobj_get_iterator): Return unique_ptr.


Adding Tom to CC.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2021-07-24 23:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-24 20:01 [Bug varobj/28131] New: " usaonmonday at gmail dot com
2021-07-24 23:53 ` usaonmonday at gmail dot com [this message]
2021-07-25 14:33 ` [Bug varobj/28131] " ssbssa at sourceware dot org
2021-07-29 13:39 ` tromey at sourceware dot org
2021-07-29 19:28 ` simark at simark dot ca
2021-07-30 17:08 ` tromey at sourceware dot org
2021-07-30 17:28 ` tromey at sourceware dot org
2021-08-02  3:06 ` usaonmonday at gmail dot com
2021-08-02 15:46 ` cvs-commit at gcc dot gnu.org
2021-08-02 16:06 ` cvs-commit at gcc dot gnu.org
2021-08-02 16:06 ` tromey at sourceware dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28131-4717-bmxmr0jMV0@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).