[Bug symtab/28159] [gdb/symtab] gdb generates .gdb_index with only empty hashtable entries, then fails to recognize it as empty

["vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=28159

--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #2)
> (In reply to Tom de Vries from comment #0)
> > This shows two problems:
> > - gdb generates such an index
> 
> Fixed by:
> ...
> diff --git a/gdb/dwarf2/index-write.c b/gdb/dwarf2/index-write.c
> index 4e00c716d91..5de07a6c07b 100644
> --- a/gdb/dwarf2/index-write.c
> +++ b/gdb/dwarf2/index-write.c
> @@ -1385,6 +1385,9 @@ write_gdbindex (dwarf2_per_objfile *per_objfile, FILE
> *out_file,
>    uniquify_cu_indices (&symtab);
>  
>    data_buf symtab_vec, constant_pool;
> +  if (symtab.n_elements == 0)
> +    symtab.data.resize (0);
> +
>    write_hash_table (&symtab, symtab_vec, constant_pool);
>  
>    write_gdbindex_1(out_file, objfile_cu_list, types_cu_list, addr_vec,
> ...

Submitted here:
https://sourceware.org/pipermail/gdb-patches/2021-August/181673.html .

-- 
You are receiving this mail because:
You are on the CC list for the bug.