From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 7BE2F3857C65; Thu, 26 Aug 2021 12:39:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7BE2F3857C65 From: "vries at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug symtab/28159] [gdb/symtab] gdb generates .gdb_index with only empty hashtable entries, then fails to recognize it as empty Date: Thu, 26 Aug 2021 12:39:05 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: symtab X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: vries at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gdb-prs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-prs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2021 12:39:05 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D28159 --- Comment #5 from Tom de Vries --- (In reply to Tom de Vries from comment #2) > (In reply to Tom de Vries from comment #0) > > This shows two problems: > > - gdb generates such an index >=20 > Fixed by: > ... > diff --git a/gdb/dwarf2/index-write.c b/gdb/dwarf2/index-write.c > index 4e00c716d91..5de07a6c07b 100644 > --- a/gdb/dwarf2/index-write.c > +++ b/gdb/dwarf2/index-write.c > @@ -1385,6 +1385,9 @@ write_gdbindex (dwarf2_per_objfile *per_objfile, FI= LE > *out_file, > uniquify_cu_indices (&symtab); >=20=20 > data_buf symtab_vec, constant_pool; > + if (symtab.n_elements =3D=3D 0) > + symtab.data.resize (0); > + > write_hash_table (&symtab, symtab_vec, constant_pool); >=20=20 > write_gdbindex_1(out_file, objfile_cu_list, types_cu_list, addr_vec, > ... Submitted here: https://sourceware.org/pipermail/gdb-patches/2021-August/181673.html . --=20 You are receiving this mail because: You are on the CC list for the bug.=