public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "simark at simark dot ca" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug symtab/28200] DW_AT_ranges handling in partial_die_info::read does not handle discontinuous ranges
Date: Fri, 06 Aug 2021 15:44:07 +0000	[thread overview]
Message-ID: <bug-28200-4717-jpVtJtVxUc@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28200-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28200

--- Comment #6 from Simon Marchi <simark at simark dot ca> ---
Here's my interpretation of your post, just to make sure I understand
correctly.

I. Looks correct
II. Looks correct
III. Now it sounds like bad debug info, because the CU's ranges is not a
superset of its children.  Unless GDB knows better (producer X produces wrong
CU ranges), I think it is correct to trust the CU's ranges, so the result shown
looks correct.  (I wouldn't mind having a maintenance mode where we compute the
ranges from the CU's children even if the CU has ranges, and compare the two
address maps to see if there's a difference.  That could mean a bug in GDB or
in the debug info.)
IV. When the CU doesn't provide ranges, we fall back on building an address map
that is the intersection of everything found under the CU.  At this point it
looks correct, because you still haven't put a "hole" in the function's ranges.
V. Now that you've put a hole in the function's ranges, we should see the hole,
therefore it's incorrect.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-08-06 15:44 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06 11:03 [Bug symtab/28200] New: " vries at gcc dot gnu.org
2021-08-06 11:04 ` [Bug symtab/28200] " vries at gcc dot gnu.org
2021-08-06 11:18 ` vries at gcc dot gnu.org
2021-08-06 11:57 ` vries at gcc dot gnu.org
2021-08-06 13:18 ` simark at simark dot ca
2021-08-06 14:23 ` vries at gcc dot gnu.org
2021-08-06 14:28 ` vries at gcc dot gnu.org
2021-08-06 15:44 ` simark at simark dot ca [this message]
2021-08-06 15:57 ` vries at gcc dot gnu.org
2021-08-06 16:46 ` simark at simark dot ca
2021-08-10 13:38 ` vries at gcc dot gnu.org
2021-08-10 15:06 ` vries at gcc dot gnu.org
2021-08-10 15:06 ` vries at gcc dot gnu.org
2021-08-24 14:29 ` brobecker at gnat dot com
2021-08-24 14:58 ` vries at gcc dot gnu.org
2021-09-14 12:41 ` cvs-commit at gcc dot gnu.org
2021-09-14 12:56 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28200-4717-jpVtJtVxUc@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).