[Bug cli/28290] pathstuff.cc:132: internal-error: gdb::unique_xmalloc_ptr<char> gdb_abspath(const char*): Assertion `path != NULL && path[0] != '\0'' failed

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=28290

--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom de Vries <vries@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=f947f96797f8ec33aabf9cd7234c850778068445

commit f947f96797f8ec33aabf9cd7234c850778068445
Author: Tom de Vries <tdevries@suse.de>
Date:   Mon Aug 30 14:34:03 2021 +0200

    [gdb/cli] Don't assert on empty string for core-file

    With current gdb we run into:
    ...
    $ gdb -batch '' ''
    : No such file or directory.
    pathstuff.cc:132: internal-error: \
      gdb::unique_xmalloc_ptr<char> gdb_abspath(const char*): \
      Assertion `path != NULL && path[0] != '\0'' failed.
    ...

    Fix this by skipping the call to gdb_abspath in core_target_open in the
    empty-string case, such that we have instead:
    ...
    $ gdb -batch '' ''
    : No such file or directory.
    : No such file or directory.
    $
    ...

    Tested on x86_64-linux.

    gdb/ChangeLog:

    2021-08-30  Tom de Vries  <tdevries@suse.de>

            PR cli/28290
            * gdb/corelow.c (core_target_open): Skip call to gdb_abspath in the
            empty-string case.

    gdb/testsuite/ChangeLog:

    2021-08-30  Tom de Vries  <tdevries@suse.de>

            PR cli/28290
            * gdb.base/batch-exit-status.exp: Add gdb '' and gdb '' '' tests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.