public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug ada/28323] segfault in ada_is_unconstrained_packed_array_type
Date: Thu, 09 Sep 2021 14:53:10 +0000	[thread overview]
Message-ID: <bug-28323-4717-H9vdGPloxu@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28323-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28323

--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
This seems to fix it:
...
$ git diff
diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index 6680a4fd657..b1ed66c12c4 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -1974,6 +1974,8 @@ ada_is_unconstrained_packed_array_type (struct type
*type)
       /* The structure's first field is a pointer to an array, so this
         fetches the array type.  */
       type = TYPE_TARGET_TYPE (type->field (0).type ());
+      if (type->code () == TYPE_CODE_TYPEDEF)
+       type = ada_typedef_target_type (type);
       /* Now we can see if the array elements are packed.  */
       return TYPE_FIELD_BITSIZE (type, 0) > 0;
     }
...

But I have no idea whether the fix is correct.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-09-09 14:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09 14:10 [Bug ada/28323] New: " vries at gcc dot gnu.org
2021-09-09 14:33 ` [Bug ada/28323] " vries at gcc dot gnu.org
2021-09-09 14:53 ` vries at gcc dot gnu.org [this message]
2021-09-09 14:59 ` vries at gcc dot gnu.org
2021-12-06 12:14 ` vries at gcc dot gnu.org
2021-12-07  6:36 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28323-4717-H9vdGPloxu@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).