public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/28404] Verify bsearch precondition in find_pc_section
Date: Fri, 01 Oct 2021 15:13:02 +0000 [thread overview]
Message-ID: <bug-28404-4717-Yy56lcHvAE@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28404-4717@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=28404
Tom de Vries <vries at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |WORKSFORME
Status|NEW |RESOLVED
--- Comment #2 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Tom de Vries from comment #0)
> Perhaps even add a verify_bsearch to gdbsupport that can be dropped in place
> to check the precondition.
That doesn't seem to be possible, since the check that we're trying to do uses
a different compare function (elem vs elem) than bsearch does (key vs elem).
Adding this code as a regular check seems somewhat expensive. So I'm leaving
things as they are for now.
Marking this fixed-worksforme.
--
You are receiving this mail because:
You are on the CC list for the bug.
prev parent reply other threads:[~2021-10-01 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 9:25 [Bug gdb/28404] New: " vries at gcc dot gnu.org
2021-10-01 15:10 ` [Bug gdb/28404] " vries at gcc dot gnu.org
2021-10-01 15:13 ` vries at gcc dot gnu.org [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-28404-4717-Yy56lcHvAE@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=gdb-prs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).