public inbox for gdb-prs@sourceware.org
help / color / mirror / Atom feed
From: "kadler at us dot ibm.com" <sourceware-bugzilla@sourceware.org>
To: gdb-prs@sourceware.org
Subject: [Bug gdb/28471] Internal error on Assertion `pid != 0' on AIX
Date: Tue, 19 Oct 2021 19:17:58 +0000	[thread overview]
Message-ID: <bug-28471-4717-EtsTz1VbpS@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-28471-4717@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=28471

--- Comment #2 from Kevin Adler <kadler at us dot ibm.com> ---
Thanks, I did make some changes last night that were along the lines you talked
about.

Firstly, functions take in a ptid_t parameter now and don't rely on
inferior_ptid.

- get_signaled_thread now returns a thread_info* and the iterate_over_threads
call from pd_update was moved there. This was only needed when pd_activate(1)
was called in pd_enable, which now calls get_signaled_thread. The
switch_to_thread call that was formerly in pd_update is now there too, since
that was the only place it was used.

- pd_update now ends after sync_threadlists.

- pd_activate no longer calls pd_update and takes no args. Callers now call
pd_update() themselves.


This seems to have fixed the issue for me. No clue whether the whole
sync_threadlists is still needed or the larger question around user-space
thread support in general.

I'll look at the other changes you mentioned: removing the scope_restorer, the
code that sets inferior_ptid, etc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2021-10-19 19:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-18 23:38 [Bug gdb/28471] New: " kadler at us dot ibm.com
2021-10-19 18:15 ` [Bug gdb/28471] " simon.marchi at polymtl dot ca
2021-10-19 19:17 ` kadler at us dot ibm.com [this message]
2022-08-05 21:26 ` kadler at us dot ibm.com
2022-08-05 21:44 ` simark at simark dot ca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-28471-4717-EtsTz1VbpS@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=gdb-prs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).