From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 45A0B3858D39; Thu, 21 Oct 2021 08:23:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 45A0B3858D39 From: "vries at gcc dot gnu.org" To: gdb-prs@sourceware.org Subject: [Bug tui/28482] [tui] nexting through hello world results in duplicate lines in source window Date: Thu, 21 Oct 2021 08:23:50 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gdb X-Bugzilla-Component: tui X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: vries at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gdb-prs@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-prs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2021 08:23:50 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D28482 --- Comment #1 from Tom de Vries --- I switched off the reverse mode point highlighting: ... diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c index afd51e95980..f0bf76b15be 100644 --- a/gdb/tui/tui-winsource.c +++ b/gdb/tui/tui-winsource.c @@ -239,13 +239,17 @@ tui_source_window_base::show_source_line (int lineno) struct tui_source_element *line; line =3D &m_content[lineno]; +#if 0 if (line->is_exec_point) tui_set_reverse_mode (m_pad.get (), true); +#endif wmove (m_pad.get (), lineno, 0); tui_puts (line->line.c_str (), m_pad.get ()); +#if 0 if (line->is_exec_point) tui_set_reverse_mode (m_pad.get (), false); +#endif } /* See tui-winsource.h. */ ... and got instead: ... 6 { 7 void *p =3D malloc (10); > 8 printf ("hello: %p\n", p); 9 return 0; > 10 } ... which fixes the duplicate line, but the old '>' marker is left, and the new= one is in the wrong place. After another next, we have: ... 6 { 7 void *p =3D malloc (10); > 8 printf ("hello: %p\n", p); 9 return 0; 10 } > 11 ... --=20 You are receiving this mail because: You are on the CC list for the bug.=