public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug tui/28483] [gdb/tui] breakpoint creation not displayed Date: Thu, 21 Oct 2021 22:28:18 +0000 [thread overview] Message-ID: <bug-28483-4717-Wae8YD4qxj@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-28483-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=28483 --- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> --- The gdb-11-branch branch has been updated by Tom de Vries <vries@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=cfd85eb3ef8d1c823daaa00783c4244089587a3a commit cfd85eb3ef8d1c823daaa00783c4244089587a3a Author: Tom de Vries <tdevries@suse.de> Date: Fri Oct 22 00:28:14 2021 +0200 [gdb/tui] Fix breakpoint display functionality In commit 81e6b8eb208 "Make tui-winsource not use breakpoint_chain", a loop body was transformed into a lambda function body: ... - for (bp = breakpoint_chain; - bp != NULL; - bp = bp->next) + iterate_over_breakpoints ([&] (breakpoint *bp) -> bool ... and consequently: - a continue was replaced by a return, and - a final return was added. Then in commit 240edef62f0 "gdb: remove iterate_over_breakpoints function", we transformed back to a loop body: ... - iterate_over_breakpoints ([&] (breakpoint *bp) -> bool + for (breakpoint *bp : all_breakpoints ()) ... but without reverting the changes that introduced the two returns. Consequently, breakpoints no longer show up in the tui source window. Fix this by reverting the changes that introduced the two returns. Build on x86_64-linux, tested with all .exp test-cases that contain tuiterm_env. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28483 gdb/ChangeLog: 2021-10-22 Tom de Vries <tdevries@suse.de> PR tui/28483 * tui/tui-winsource.c (tui_source_window_base::update_breakpoint_info): Fix returns in loop body. gdb/testsuite/ChangeLog: 2021-10-22 Tom de Vries <tdevries@suse.de> PR tui/28483 * gdb.tui/break.exp: New file. -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2021-10-21 22:28 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-21 11:20 [Bug tui/28483] New: " vries at gcc dot gnu.org 2021-10-21 11:20 ` [Bug tui/28483] " vries at gcc dot gnu.org 2021-10-21 11:30 ` vries at gcc dot gnu.org 2021-10-21 22:28 ` cvs-commit at gcc dot gnu.org [this message] 2021-10-21 22:29 ` vries at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-28483-4717-Wae8YD4qxj@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).