public inbox for gdb-prs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla@sourceware.org> To: gdb-prs@sourceware.org Subject: [Bug cli/28833] Ctrl-D distorts GDB prompt Date: Fri, 22 Apr 2022 17:51:35 +0000 [thread overview] Message-ID: <bug-28833-4717-oO7shrY9cC@http.sourceware.org/bugzilla/> (raw) In-Reply-To: <bug-28833-4717@http.sourceware.org/bugzilla/> https://sourceware.org/bugzilla/show_bug.cgi?id=28833 --- Comment #14 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Andrew Burgess <aburgess@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=b913bd98ce81a1600463f9a8a30db04d44b64a47 commit b913bd98ce81a1600463f9a8a30db04d44b64a47 Author: Andrew Burgess <aburgess@redhat.com> Date: Tue Mar 29 15:07:04 2022 +0100 gdb: improved EOF handling when using readline 7 In this commit: commit a6b413d24ccc5d76179bab866834e11fd6fec294 Date: Fri Mar 11 14:44:03 2022 +0000 gdb: work around prompt corruption caused by bracketed-paste-mode a change was made to GDB to work around bug PR gdb/28833. The consequence of this work around is that, when bracketed paste mode is enabled in readline, and GDB is quit by sending EOF, then the output will look like this: (gdb) quit The ideal output, which is what we get when bracketed paste mode is off, is this: (gdb) quit The reason we need to make this change is explained in the original commit referenced above. What isn't mentioned in the above commit, is that the change that motivated this work around was only added in readline 8, older versions of readline don't require the change. In later commits in this series I will add a fix to GDB's in-tree copy of readline (this fix is back-ported from upstream readline), and then I will change GDB so that, when using the (patched) in-tree readline, we can have the ideal output in all cases. However, GDB can be built against the system readline. When this is done, and the system readline is version 8, then we will still have to use the work around (two line) style output. But, if GDB is built against the system readline, and the system readline is an older version 7 readline, then there's no reason why we can't have the ideal output, after all, readline 7 doesn't include the change that we need to work around. This commit changes GDB so that, when using readline 7 we get the ideal output in all cases. This change is trivial (a simple check against the readline version number) so I think this should be fine to include. For testing this commit, you need to configure GDB including the '--with-system-readline' flag, and build GDB on a system that uses readline 7, for example 'Ubuntu 18.04'. Then run the test 'gdb.base/eof-exit.exp', you should expect everything to PASS. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28833 -- You are receiving this mail because: You are on the CC list for the bug.
next prev parent reply other threads:[~2022-04-22 17:51 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-28 9:32 [Bug cli/28833] New: " tankut.baris.aktemur at intel dot com 2022-01-28 9:34 ` [Bug cli/28833] " tankut.baris.aktemur at intel dot com 2022-01-28 9:36 ` tankut.baris.aktemur at intel dot com 2022-01-28 16:07 ` tromey at sourceware dot org 2022-02-06 12:14 ` aburgess at redhat dot com 2022-02-07 10:28 ` tankut.baris.aktemur at intel dot com 2022-02-08 10:15 ` aburgess at redhat dot com 2022-02-14 12:14 ` blarsen at redhat dot com 2022-02-15 11:48 ` aburgess at redhat dot com 2022-02-15 12:34 ` schwab@linux-m68k.org 2022-02-15 14:01 ` aburgess at redhat dot com 2022-02-16 17:06 ` aburgess at redhat dot com 2022-02-17 7:01 ` tankut.baris.aktemur at intel dot com 2022-02-27 11:21 ` brobecker at gnat dot com 2022-03-06 10:05 ` brobecker at gnat dot com 2022-03-07 15:14 ` aburgess at redhat dot com 2022-03-16 20:44 ` cvs-commit at gcc dot gnu.org 2022-04-22 17:51 ` cvs-commit at gcc dot gnu.org [this message] 2022-04-22 17:51 ` cvs-commit at gcc dot gnu.org 2022-04-22 17:51 ` cvs-commit at gcc dot gnu.org 2022-04-22 17:53 ` aburgess at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-28833-4717-oO7shrY9cC@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=gdb-prs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).