[Bug build/28994] New: [build] Werror=deprecated-declarations for scm_install_gmp_memory_functions

[Bug build/28994] New: [build] Werror=deprecated-declarations for scm_install_gmp_memory_functions

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28994

            Bug ID: 28994
           Summary: [build] Werror=deprecated-declarations for
                    scm_install_gmp_memory_functions
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: vries at gcc dot gnu.org
  Target Milestone: ---

On openSUSE tumbleweed I run into:
...
/data/vries/gdb_versions/devel/src/gdb/guile/guile.c: In function 'void
gdbscm_initialize(const extension_language_defn*)':
/data/vries/gdb_versions/devel/src/gdb/guile/guile.c:676:5: error:
'scm_install_gmp_memory_functions' is deprecated
[-Werror=deprecated-declarations]
  676 |     scm_install_gmp_memory_functions = 0;
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/guile/3.0/libguile.h:128,
                 from
/data/vries/gdb_versions/devel/src/gdb/guile/guile-internal.h:30,
                 from /data/vries/gdb_versions/devel/src/gdb/guile/guile.c:36:
/usr/include/guile/3.0/libguile/deprecated.h:164:20: note: declared here
  164 | SCM_DEPRECATED int scm_install_gmp_memory_functions;
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[1]: *** [Makefile:1659: guile/guile.o] Error 1
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug guile/28994] [build] Werror=deprecated-declarations for scm_install_gmp_memory_functions

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28994

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org
          Component|build                       |guile

--- Comment #1 from Tom Tromey <tromey at sourceware dot org> ---
Probably more of a guile thing than a build thing.
I assume some porting work is required for 3.0?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug guile/28994] [build] Werror=deprecated-declarations for scm_install_gmp_memory_functions

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28994

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lienze at sourceware dot org

--- Comment #2 from Tom Tromey <tromey at sourceware dot org> ---
*** Bug 29129 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug guile/28994] [build] Werror=deprecated-declarations for scm_install_gmp_memory_functions

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28994

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ludo at gnu dot org

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug guile/28994] [build] Werror=deprecated-declarations for scm_install_gmp_memory_functions

[ludo at gnu dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28994

--- Comment #3 from Ludovic Courtès <ludo at gnu dot org> ---
Hi,

(In reply to Tom Tromey from comment #1)
> Probably more of a guile thing than a build thing.
> I assume some porting work is required for 3.0?

'scm_install_gmp_memory_functions' is deprecated in Guile 3.0.8 (not 3.0.7),
because Guile 3.0.8 no longer relies on custom GMP allocators; thus, setting
this variable doesn't have any effect.

The variable will remain for the whole 3.0.x series so I'd recommend
-Wno-error=deprecated-declarations or a pragma to the same effect.

Thoughts?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug guile/28994] [build] Werror=deprecated-declarations for scm_install_gmp_memory_functions

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28994

--- Comment #4 from Tom Tromey <tromey at sourceware dot org> ---
If the warning can be disabled locally then that would be best.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug guile/28994] [build] Werror=deprecated-declarations for scm_install_gmp_memory_functions

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28994

--- Comment #5 from Tom de Vries <vries at gcc dot gnu.org> ---
Once more noted at
https://sourceware.org/pipermail/gdb-patches/2022-July/190524.html .

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug guile/28994] [build] Werror=deprecated-declarations for scm_install_gmp_memory_functions

[ludo at gnu dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28994

--- Comment #6 from Ludovic Courtès <ludo at gnu dot org> ---
(In reply to Tom de Vries from comment #5)
> Once more noted at
> https://sourceware.org/pipermail/gdb-patches/2022-July/190524.html .

As suggested earlier, how about something along these lines:

  /* This variable is deprecated in Guile 3.0.8 and later but remains
     available in the whole 3.0 series.  */
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
  scm_install_gmp_memory_functions = 0;
#pragma GCC diagnostic pop

If that's fine with you, I'd prefer to let you check this in as I'm lacking the
bandwidth to do more currently.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug guile/28994] [build] Werror=deprecated-declarations for scm_install_gmp_memory_functions

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28994

--- Comment #7 from Tom de Vries <vries at gcc dot gnu.org> ---
(In reply to Ludovic Courtès from comment #6)
> (In reply to Tom de Vries from comment #5)
> > Once more noted at
> > https://sourceware.org/pipermail/gdb-patches/2022-July/190524.html .
> 
> As suggested earlier, how about something along these lines:
> 
>   /* This variable is deprecated in Guile 3.0.8 and later but remains
>      available in the whole 3.0 series.  */
> #pragma GCC diagnostic push
> #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
>   scm_install_gmp_memory_functions = 0;
> #pragma GCC diagnostic pop
> 
> If that's fine with you, I'd prefer to let you check this in as I'm lacking
> the bandwidth to do more currently.

Works for me.

I've also added a test on SCM_MAJOR/MINOR_VERSION to make sure we don't run
into trouble once the variable is removed:
...
diff --git a/gdb/guile/guile.c b/gdb/guile/guile.c
index 14b191ded62..e5565b627d9 100644
--- a/gdb/guile/guile.c
+++ b/gdb/guile/guile.c
@@ -677,7 +677,17 @@ gdbscm_initialize (const struct extension_language_defn
*ext
lang)
        "double free or corruption (out)" error.
        Work around the libguile bug by disabling the installation of the
        libgmp memory functions by guile initialization.  */
+
+    /* The scm_install_gmp_memory_functions variable should be removed after
+       version 3.0, so limit usage to 3.0 and before.  */
+#if SCM_MAJOR_VERSION < 3 || (SCM_MAJOR_VERSION == 3 && SCM_MINOR_VERSION == 0
)
+    /* This variable is deprecated in Guile 3.0.8 and later but remains
+       available in the whole 3.0 series.  */
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
     scm_install_gmp_memory_functions = 0;
+#pragma GCC diagnostic pop
+#endif-

     /* scm_with_guile is the most portable way to initialize Guile.  Plus
        we need to initialize the Guile support while in Guile mode (e.g.,
...

WDYT?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug guile/28994] [build] Werror=deprecated-declarations for scm_install_gmp_memory_functions

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28994

--- Comment #8 from Tom de Vries <vries at gcc dot gnu.org> ---
submitted: https://sourceware.org/pipermail/gdb-patches/2022-July/190551.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug guile/28994] [build] Werror=deprecated-declarations for scm_install_gmp_memory_functions

[ludo at gnu dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28994

--- Comment #9 from Ludovic Courtès <ludo at gnu dot org> ---
(In reply to Tom de Vries from comment #8)
> submitted: https://sourceware.org/pipermail/gdb-patches/2022-July/190551.html

Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug guile/28994] [build] Werror=deprecated-declarations for scm_install_gmp_memory_functions

[vries at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=28994

Tom de Vries <vries at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.1
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #10 from Tom de Vries <vries at gcc dot gnu.org> ---
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=57f8fe908bec51c40ec686294460ec979b140843

-- 
You are receiving this mail because:
You are on the CC list for the bug.