[Bug build/29003] New: "make TAGS" fails in the gdbserver directory

[Bug build/29003] New: "make TAGS" fails in the gdbserver directory

[eliz at gnu dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29003

            Bug ID: 29003
           Summary: "make TAGS" fails in the gdbserver directory
           Product: gdb
           Version: HEAD
            Status: NEW
          Severity: normal
          Priority: P2
         Component: build
          Assignee: unassigned at sourceware dot org
          Reporter: eliz at gnu dot org
  Target Milestone: ---

Like this:

$ make TAGS
etags \
  `for i in yzzy x86-low.o nat/x86-dregs.o win32-low.o win32-i386-low.o
nat/windows-nat.o arch/i386.o ; do \
     if [ x$i != xyzzy ]; then \
       echo ./$i | sed -e 's/\.o$/\.cc/' \
         -e 's,/\(arch\|nat\|target\)/,/../\1/,' \
     fi; \
   done` \
  ./debug.cc  ./dll.cc  ./gdbreplay.cc  ./hostio.cc  ./i387-fp.cc 
./inferiors.cc  ./linux-aarch64-low.cc  ./linux-arc-low.cc  ./linux-arm-low.cc 
./linux-ia64-low.cc  ./linux-low.cc  ./linux-m68k-low.cc  ./linux-mips-low.cc 
./linux-nios2-low.cc  ./linux-or1k-low.cc  ./linux-ppc-low.cc 
./linux-riscv-low.cc  ./linux-s390-low.cc  ./linux-sh-low.cc 
./linux-sparc-low.cc  ./linux-x86-low.cc  ./linux-xtensa-low.cc  ./mem-break.cc
 ./netbsd-aarch64-low.cc  ./netbsd-amd64-low.cc ./netbsd-i386-low.cc 
./netbsd-low.cc  ./netbsd-low.h  ./proc-service.cc  ./proc-service.list 
./regcache.cc  ./remote-utils.cc  ./server.cc  ./symbol.cc  ./target.cc 
./thread-db.cc  ./utils.cc  ./win32-i386-low.cc  ./win32-low.cc  ./x86-low.cc 
./../gdb/alloc.c  ./../gdb/arch/arc.c  ./../gdb/arch/arm.c 
./../gdb/arch/arm-get-next-pcs.c  ./../gdb/arch/arm-linux.c 
./../gdb/arch/ppc-linux-common.c  ./../gdb/arch/riscv.c 
./../gdb/nat/aarch64-mte-linux-ptrace.c 
./../gdb/nat/aarch64-sve-linux-ptrace.c  ./../gdb/nat/linux-btrace.c 
./../gdb/nat/linux-namespaces.c  ./../gdb/nat/linux-osdata.c 
./../gdb/nat/linux-personality.c  ./../gdb/nat/mips-linux-watch.c 
./../gdb/nat/ppc-linux.c  ./../gdb/nat/riscv-linux-tdesc.c 
./../gdb/nat/fork-inferior.c  ./../gdb/target/waitstatus.c
/bin/sh: command substitution: line 6: syntax error near unexpected token
`done'

/bin/sh: command substitution: line 6: `for i in yzzy x86-low.o nat/x86-dregs.o
win32-low.o win32-i386-low.o nat/windows-nat.o arch/i386.o ; do      if [ x$i
!=  xyzzy ]; then        echo ./$i | sed -e 's/\.o$/\.cc/'          -e
's,/\(arch\|nat\|target\)/,/../\1/,'      fi;    done'

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29003] "make TAGS" fails in the gdbserver directory

[schwab@linux-m68k.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29003

--- Comment #1 from Andreas Schwab <schwab@linux-m68k.org> ---
I think there is a semicolon missing before fi.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29003] "make TAGS" fails in the gdbserver directory

[eliz at gnu dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29003

--- Comment #2 from Eli Zaretskii <eliz at gnu dot org> ---
(In reply to Andreas Schwab from comment #1)
> I think there is a semicolon missing before fi.

Thanks.

Yes, this solves the problem for me:

TAGS:   ${TAGFILES}
        etags \
          `for i in yzzy ${DEPFILES}; do \
             if [ x$$i != xyzzy ]; then \
               echo ${srcdir}/$$i | sed -e 's/\.o$$/\.cc/' \
                 -e 's,/\(arch\|nat\|target\)/,/../\1/,'; \
             fi; \
           done` \
          ${TAGFILES}

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29003] "make TAGS" fails in the gdbserver directory

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29003

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tromey at sourceware dot org
           Assignee|unassigned at sourceware dot org   |tromey at sourceware dot org

--- Comment #3 from Tom Tromey <tromey at sourceware dot org> ---
https://sourceware.org/pipermail/gdb-patches/2022-December/195066.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29003] "make TAGS" fails in the gdbserver directory

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29003

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=bd3014572d687e6d6e9d27a46d5b19a4a5528e85

commit bd3014572d687e6d6e9d27a46d5b19a4a5528e85
Author: Tom Tromey <tom@tromey.com>
Date:   Fri Dec 23 13:28:20 2022 -0700

    Fix 'make TAGS' in gdbserver

    PR build/29003 points out that "make TAGS" is broken in gdbserver.
    This patch fixes the problem that is pointed out there, plus another
    one I noticed while working on that -- namely that the "sed" computes
    the wrong names for some source files.  Finally, a couple of obsolete
    variable references are removed.

    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29003

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug build/29003] "make TAGS" fails in the gdbserver directory

[tromey at sourceware dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29003

Tom Tromey <tromey at sourceware dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |14.1
         Resolution|---                         |FIXED

--- Comment #5 from Tom Tromey <tromey at sourceware dot org> ---
Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.